Re: [boost] [fiber] PR: Replace #include "Windows.h" by "windows.h"

Subject: Re: [boost] [fiber] PR: Replace #include "Windows.h" by "windows.h"
From: Frédéric Bron (frederic.bron_at_[hidden])
Date: 2017-07-14 18:43:52

>> I have just checked and both mingw and mingw-w64 have only fully lower
>> case
>> headers.

I just checked all includes files from boost (1.65.0 beta2) that have
upper case character in their names and are present in mingw or
mingw-w64 in lower case. Here is what I found: 3 files, Activation.h,
Memory.h, Windows.h.

Those are in the following files:
./libs/thread/src/win32/thread.cpp:36:#include <Activation.h>
./libs/iostreams/test/windows_pipe_test.cpp:9:#include <Windows.h>
./libs/process/test/bind_stderr.cpp:32:#   include <Windows.h>
./libs/process/test/bind_stdin.cpp:34:#   include <Windows.h>
./libs/process/test/sparring_partner.cpp:31:#   include <Windows.h>
./libs/process/test/bind_stdout_stderr.cpp:30:#   include <Windows.h>
./libs/process/test/exit_code.cpp:21:#   include <Windows.h>
./libs/process/test/bind_stdout.cpp:32:#   include <Windows.h>
./libs/process/test/group.cpp:32:#   include <Windows.h>
./libs/process/test/spawn.cpp:33:#   include <Windows.h>
./libs/process/test/spawn_fail.cpp:29:#   include <Windows.h>
./libs/process/test/system_test1.cpp:38:#   include <Windows.h>
./tools/build/src/engine/boehm_gc/MacOS.c:19:#include <Memory.h>
./boost/fiber/detail/futex.hpp:21:#include <Windows.h>
./boost/fiber/detail/cpu_relax.hpp:19:# include <Windows.h>

So that is not a lot. For Memory.h, it seems related to MacOS, not Windows.
If people really want to keep the upper case letter, we could then have
#ifdef __MINGW32__
#include "windows.h"
#else
#include "Windows.h"
#endif

Frédéric

Frédéric