[boost] [detail] boost/detail/utf8_codecvt_facet.hpp broken by recent change

Subject: [boost] [detail] boost/detail/utf8_codecvt_facet.hpp broken by recent change
From: Beman Dawes (bdawes_at_[hidden])
Date: 2017-08-25 13:09:14

 boost/detail/utf8_codecvt_facet.hpp fails to compile for STL's MinGW
distro from https://nuwen.net/mingw.html

The error message is:

..\..\../boost/detail/utf8_codecvt_facet.hpp:117:29: error: function
'boost::filesystem::detail::utf8_codecvt_facet::~utf8_codecvt_facet()'
definition is marked dllimport
     virtual BOOST_UTF8_DECL ~utf8_codecvt_facet(){}

The problem (on develop) is caused by Robert Ramey's Aug 13 commit
73c12230c31a851c15ecb9a649468425ebd92f8e "adjustment to avoid linking
problem: vtable not found found for ~utf8_codecvt_facet.hpp" which added
"BOOST_UTF8_DECL" to line 117.

This is breaking my local filesystem tests for GCC/MinGW. If the change is
reverted, the tests start passing again.

Robert, could you please revert the change? I can also to it, but thought
you needed to be alerted first so you can revisit whatever you were trying
to fix.

Thanks,

--Beman