Re: [boost] Please fix executable permissions on header files

Subject: Re: [boost] Please fix executable permissions on header files
From: James E. King, III (jking_at_[hidden])
Date: 2017-09-25 16:45:04

On Mon, Sep 25, 2017 at 12:35 PM, Daniel James via Boost <
boost_at_[hidden]> wrote:

> On 25 September 2017 at 14:52, Edward Diener via Boost
> <boost_at_[hidden]> wrote:
> >
> > A better solution would be a Git server hook which would prevent files
> being
> > pushed as executable unless the file matched known executable file types.
>
> I don't think we can add server hooks to github.
>
> > Of
> > course determining what constitutes executable file types might not be
> very
> > easy. I believe a git hook at the Boost superproject level would apply to
> > all submodules recursively, but I am not absolutely sure that this is
> true.
>
> I don't think so, although someone with more experience might know better?
>
> I could perhaps check in the commitbot, but I don't really want it to
> reject changes. There's no good feedback mechanism, and it would
> increase the amount of state it would need to manage. It might also
> lead to issues if two modules are updated, but the commitbot only
> accepts one.
>
> Could perhaps add something to the '__boost_check_library__' tests,
> which is at 'status/boost_check_library.py'.
>
>
Perhaps bjam could include a check for it so that it fails locally before
push and also in CI.  This would be a good place to put other checks like
boost license conformance.

- Jim