Re: [boost] [release] Boost 1.66.0 Release Candidate 2

Subject: Re: [boost] [release] Boost 1.66.0 Release Candidate 2
From: Andrey Semashev (andrey.semashev_at_[hidden])
Date: 2017-12-18 13:59:58

On 12/18/17 16:35, Daniel James via Boost wrote:
> On 18 December 2017 at 12:54, Andrey Semashev via Boost
> <boost_at_[hidden]> wrote:
>>
>> So, to summarise:
>>
>> - the problem was found and fixed in develop
>> - it didn't appear in master and should not affect the release because
>> Boost.Thread was not merged
>> - I have now merged Boost.Log to master, so even if Boost.Thread is merged,
>> it should still be fine
> 
> Just to be clear, as I think I need to fully understand this. The
> problem in issue #44 is that a lookup for 'winapi' from inside
> 'boost::detail' picks up the 'boost::detail::winapi' namespace from
> your log header, but without including the header that sets up the
> 'boost::detail::winapi' namespace to import all of 'boost::winapi'.

Correct. The updated Boost.Thread includes the new Boost.WinAPI headers 
which define its symbols in `boost::winapi`, so Boost.Thread expects 
`winapi` to resolve to `boost::winapi`.

> The master branch of Boost.Thread does include the header, so there's
> no problem there. And this can only happen inside 'boost::detail', so
> it shouldn't ever affect user code.

Also correct. And user's code should not use Boost.WinAPI in the first 
place.