Re: [boost] [review] Review of Outcome v2 (Fri-19-Jan to Sun-28-Jan, 2018)

Subject: Re: [boost] [review] Review of Outcome v2 (Fri-19-Jan to Sun-28-Jan, 2018)
From: Niall Douglas (s_sourceforge_at_[hidden])
Date: 2018-01-28 23:43:18

> I cloned the library locally and integrated it into Boost 1.66.0 as
> described in the documentation. Using this augmented Boost 1.66.0, I ran
> all of my tests and the evaluation with Visual Studio 2017 Update 5
> (i.e. toolset 19.12). As already pointed out, the compiler from toolset
> 19.12 will ice in such a scenario. Therefore I upgraded the toolset to
> version 19.13.26122 (the latest daily toolset version as of today) and
> configured my VS test solutions and the commandline environment to
> pick-up this toolset version.
> 
> With this setup in place, I first ran the test-suite which passed
> without failures or compiler warnings at /W4 /std:c++latest
> /permissive-. Great! Then I compiled and ran the code snippets from the
> documentation subdirectory while studying the tutorial. Those are fine
> as well. Beyond that I plugged result<> into our own sources where we
> use a similar but much less sophisticated class for the same purpose.
> This turned out to work well, too.

Ok, so trunk MSVC is fixed. Very useful to know, thanks!

>> - Do you think the library should be accepted as a Boost library?
> 
> *yes* without conditions.

Thank you for the review!

Niall

-- 
ned Productions Limited Consulting
http://www.nedproductions.biz/ http://ie.linkedin.com/in/nialldouglas/