Re: [boost] [cmake] Pull request announcement

Subject: Re: [boost] [cmake] Pull request announcement
From: Louis Dionne (ldionne.2_at_[hidden])
Date: 2018-09-20 18:48:42

On Tue, Sep 18, 2018 at 12:23 PM Zach Laine <whatwasthataddress_at_[hidden]>
wrote:

> On Tue, Sep 18, 2018 at 10:52 AM Roger Leigh via Boost <
> boost_at_[hidden]> wrote:
>
>> On 18/09/18 16:43, Zach Laine via Boost wrote:
>> > On Tue, Sep 18, 2018 at 10:39 AM Alexander Grund via Boost <
>> > boost_at_[hidden]> wrote:
>> >
>> >>
>> >>>> E.g. "yap", "hana" and "callable_traits" each try to create a target
>> >>>> "check".
>> >>>>
>> >>> What's wrong with that (not upset, just curious)?
>> >> They conflict with each other. Targets need to have unique names.
>> >>
>> >
>> > Ah, of course, thanks.  Do you have a preferred way to address this?
>> > F.ex., I only care about the "check" target in independent builds of
>> Yap,
>> > mainly for Yap-only Travis CI.  I could always turn it on conditional
>> on a
>> > CI configuration variable I cold define.
>>
>> One possibility:
>>
>> if(NOT TARGET check)
>>    create_custom_target(check DEPENDS foo-check)
>> else()
>>    add_dependencies(check foo-check)
>> endif()
>>
>> The top-level CMakeLists.txt would need to define an empty check target
>> up front which the else() case will add the local check target to.
>>
>
> I like this. Louis and Barrett, if I were to make a PR for each of your
> repos, would you find this acceptable too?
>

Thanks for the PR. Merged.

Louis

>
> Zach
>