Re: Warning from Boost.Exception

From: Alexander Grund (alexander.grund_at_[hidden])
Date: 2019-10-15 07:06:03

Am 14.10.19 um 21:28 schrieb Emil Dotchevski via Boost:
> On Mon, Oct 14, 2019 at 9:36 AM Paul A Bristow via Boost <
> boost_at_[hidden]> wrote:
>
>> Using Clang 9 on Windows  b2 toolset-clang-linux cxxstd=2a  .
>>
>> I am seeing lots of these warnings
>>
>> In file included from ..\..\..\boost/test/included/unit_test.hpp:23:
>> In file included from ..\..\..\boost/test/impl/execution_monitor.ipp:37:
>> In file included from
>> ..\..\..\boost/exception/diagnostic_information.hpp:11:
>> ..\..\..\boost/exception/info.hpp:134:21: warning: delete called on
>> non-final
>> 'boost::exception_detail::error_info_container_impl'
>>   that has virtual functions but non-virtual destructor
>>
>> [-Wdelete-non-abstract-non-virtual-dtor]
>>                      delete this;
>>                      ^
>> It seems that trying to supress is ineffective with
>>
>>    -Wno-delete-non-abstract-non-virtual-dtor
>>
>> Perhaps by design?
>>
>>
>> https://releases.llvm.org/9.0.0/tools/clang/docs/DiagnosticsReference.html#wdele
>> te-non-abstract-non-virtual-dtor
>> <https://releases.llvm.org/9.0.0/tools/clang/docs/DiagnosticsReference.html#wdelete-non-abstract-non-virtual-dtor>
>> -Wdelete-non-abstract-non-virtual-dtor
>> <
>> https://releases.llvm.org/9.0.0/tools/clang/docs/DiagnosticsReference.html>
>>
>> Diagnostic text:
>> warning:        delete
>>
>> destructor
>>
>>           called on non-final B that has virtual functions but non-virtual
>> destructor
>> -Wdelete-non-virtual-dtor
>> <
>> https://releases.llvm.org/9.0.0/tools/clang/docs/DiagnosticsReference.html>
>>
>> Some of the diagnostics controlled by this flag are enabled by default.
>> Controls -Wdelete-abstract-non-virtual-dtor
>> <
>> https://releases.llvm.org/9.0.0/tools/clang/docs/DiagnosticsReference.html>
>> ,
>> -Wdelete-non-abstract-non-virtual-dtor
>> <
>> https://releases.llvm.org/9.0.0/tools/clang/docs/DiagnosticsReference.html>
>> .
>> Should I be concerned about this?
>>
> You shouldn't be concerned about this and also you shouldn't be getting
> warnings. What platforms, what command line?

This seems to be the same issue as 
https://github.com/boostorg/exception/issues/23

|boost_warnings_minimal_demo\boost_1_64_0\boost/exception/exception.hpp(176): 
error C4265: 'boost::exception_detail::error_info_container': class has 
virtual functions, but destructor is not virtual |

Where does 'exception.hpp' come from? I'd expect it at 
https://github.com/boostorg/exception/tree/develop/include/boost/exception/exception.hpp 
but it isn't there...