Re: [FixedString] Deniz' review

From: Vinnie Falco (vinnie.falco_at_[hidden])
Date: 2019-11-26 22:30:16

On Tue, Nov 26, 2019 at 1:48 PM Mike via Boost <boost_at_[hidden]> wrote:
> As the message states, you have to explicitly specify the binary directory:
>
> add_subdirectory (../bench bench )
> add_subdirectory (../example example)
> add_subdirectory (../test test)

Doesn't work:

    $ cmake ../tools
    -- Selecting Windows SDK version 10.0.17763.0 to target Windows 10.0.18362.
    -- Configuring done
    CMake Error at
C:/Users/vinnie/src/boost/libs/json/bench/CMakeLists.txt:33
(add_executable):
     Cannot find source file:

        C:/Users/vinnie/src/boost/libs/json/tools/include/boost/json.hpp

.../json/tools/include/ is the wrong path, it should be
../json/include/. I tried all of these variations:

add_subdirectory (../bench ..)
add_subdirectory (../example ..)
add_subdirectory (../test ..)

add_subdirectory (../bench ../bench)
add_subdirectory (../example ../example)
add_subdirectory (../test ../test)

add_subdirectory (../bench .)
add_subdirectory (../example .)
add_subdirectory (../test .)

Maybe you could submit a pull request which moves the top level
CMakeLists.txt into tools/ ?

<https://github.com/vinniefalco/json>

Regards