Re: [FixedString] Deniz' review

From: Gavin Lambert (boost_at_[hidden])
Date: 2019-11-27 05:18:27

On 27/11/2019 18:02, Krystian Stasiowski wrote:
>>   At the top of this file we have `#define
>> BOOST_FIXED_STRING_USE_BOOST`, which therefore makes all following
>> conditional definitions always use Boost equivalents of standard library
>> types internally.
> 
> Well, it *is* the config, so that is where the user can decide on whether
> the library is boost dependent or not.

Users of Boost libraries are not expected to modify Boost source files, 
including header files, and in particular including config.hpp header files.

Those files are supposed to be used to detect and translate "external" 
configuration options (either defined by the user before including the 
library or from Boost.Predef or Boost.Config) to "internal" ones used 
within the library.

Unconditionally defining something in a config.hpp is therefore usually 
incorrect.

Also, you appear to be replying to posts in the thread different from 
the ones that you are quoting, which makes following the chain in a 
threaded email client tricky.