Re: [review][fixed_string] Andrzej's feedback

From: Peter Dimov (pdimov_at_[hidden])
Date: 2019-12-04 22:54:10

Gavin Lambert wrote:

> Asserts and unreachables both disappear in release builds, ...

Unreachables don't just disappear, they take parts of the code with them. 
Misguided ideas like "let's use __builtin_unreachable for the preconditions" 
are exactly why I prefer the behavior on critical precondition violations 
specified, rather than undefined, even though undefined might theoretically 
be better.