Re: [release] 1.72.0 post-beta merges

From: Tom Kent (lists_at_[hidden])
Date: 2019-12-06 21:35:39

On Thu, Dec 5, 2019 at 10:15 AM Daniela Engert via Boost <
boost_at_[hidden]> wrote:

> Hi Tobias!
>
> Am 05.12.2019 um 16:16 schrieb Tobias Loew via Boost:
> > Could someone please have a look at
> >
> http://boost.2283326.n4.nabble.com/release-proto-MSVC-19-24-28314-VS-2019-16-4-0-won-t-compile-proto-s-generate-hpp-td4710720.html
> > cause it's a showstopper for the latest VS 2019 (16.4.0).
> >
> > It's not an error introduced in 1.72 but already there for a long time,
> and
> > now the latest MSVC version produces an error on that MSVC-workaround.
>
> I've noticed this as well, today. As a quick hack I simply disabled the
> workaround at line 233 for BOOST_MSVC >= 1924. Obviously, the problem
> mentioned by the dead link is no longer a thing. With this modification,
> Boost.Log is successfully compiling again.
>
> Ciao
>   Dani
>

Can you verify that this is only VS 16.4.0 and doesn't apply to 16.3.x? If
so, that is scary.

Tom