Re: [review][LEAF] Review of LEAF starts today : May 22 - May 31

From: Krystian Stasiowski (sdkrystian_at_[hidden])
Date: 2020-05-30 05:27:27

- What is your evaluation of the design?

It's very clean. While I'm not a big fan of the macros, I do like how it's
somewhat
reminiscent of vanilla C++ exceptions. Some minor nit-picking here:
trailing underscores
following names that are public doesn't look particularly right; makes it
look like you're using you
aren't supposed to :)

- What is your evaluation of the documentation?

The documentation is great -- in terms of styles it's probably the best
I've seen for a C++ library.
The examples are great and they do a good job of communicating how the
library works by providing
realistic scenarios. It's quite well done.

- What is your evaluation of the potential usefulness of the library?

While this is not something I have found a need for, the motivation for
this libraries existence is weill founded and I can see use cases for it.

- Did you try to use the library? With which compiler(s)? Did you have any
problems?

I did not.

- How much effort did you put into your evaluation? A glance? A quick
reading? In-depth study?

I spent about an hour going through the documentation.

- Are you knowledgeable about the problem domain?

Not really :)

In terms of acceptance, I'm neutral on that front as this is not something
I am well versed in.