Re: [release] 1.74.0 post-beta merges

From: Marshall Clow (mclow.lists_at_[hidden])
Date: 2020-07-16 15:56:35

On Jul 16, 2020, at 8:47 AM, Jeff Garland <azswdude_at_[hidden]> wrote:
> 
> The wiki doesn't address adding test cases directly -- it only says no code changes -- hence the question.
> 
> And now that I look at the actual pull request to master, my memory of the timing of my last sync is faulty. Sadly, not surprising. So there are 2 actual header changes (despite github claiming that there are many more merges needed in the pull I've reverified that master has everything except these 2 changes).   One shuts down some warnings and the other fixes a bug in the constexpr implementation -- which I would like to close out in 1.74.  Note that I have verified these on 5 versions of gcc in every mode from 98 to 2a -- and clang 10.  And of course on develop for ~1 week with good tests.  
> 
> Let me know.
> 
> https://github.com/boostorg/date_time/pull/164/commits/77495803c131764f44a5c4d2227883d8c6812ead <https://github.com/boostorg/date_time/pull/164/commits/77495803c131764f44a5c4d2227883d8c6812ead>
> https://github.com/boostorg/date_time/pull/164/commits/247424d08de4587c7045467e172414b4ce9d4b20 <https://github.com/boostorg/date_time/pull/164/commits/247424d08de4587c7045467e172414b4ce9d4b20>
Go ahead.

— Marshall

> 
> 
> 
> On Thu, Jul 16, 2020 at 6:26 AM Marshall Clow <mclow.lists_at_[hidden] <mailto:mclow.lists_at_[hidden]>> wrote:
> On Jul 16, 2020, at 6:02 AM, Jeff Garland <azswdude_at_[hidden] <mailto:azswdude_at_[hidden]>> wrote:
>> 
>> I'd like to merge this one.  It's docs, but there is a 'code change', to add some tests -- no core library changes.  Asking since wasn't sure how that fit into the policy. Committed 3 days ago - test board looks good.
>> 
>> https://github.com/boostorg/date_time/pull/163/commits <https://github.com/boostorg/date_time/pull/163/commits>
> Go ahead.
> — Marshall
> 
> P.S. I don’t think you have to ask to add tests.
>