Re: [JSON][Review] Boost Json Review

From: Vinnie Falco (vinnie.falco_at_[hidden])
Date: 2020-09-20 23:25:23

On Sun, Sep 20, 2020 at 4:07 PM Maximilian Riemensberger via Boost
<boost_at_[hidden]> wrote:
> I recommend ACCEPTing the library into boost.

Thank you for your thoughtful review and the time you spent evaluating
the library.

> - The `value::is_xxx` functions inconsistently return bools or pointers.

Yes this was a design mistake, which we have reverted in develop.
`value::if_*`, `array::if_*` and `object::if_*` all consistently
return pointers, while `value::is_*` returns a bool. Your feedback
helped us understand the flaw :)

Thanks