[PFR][review] Result

From: Benedek Thaler (thalerbenedek_at_[hidden])
Date: 2020-10-08 10:51:14

Thanks to all of you who participated in the formal review of PFR,
henceforth known as Boost.PFR, and Antony Polukhin for submitting this
magical library.

PFR is ACCEPTed into Boost, with the following results:

ACCEPT: 5 votes
CONDITIONAL ACCEPT: 1 vote
REJECT: 0 votes

Reviewers highlighted that the library is "very useful", "magical" and
"provides a form of reflection in a simpler manner than other
solutions thus far".

During the review, several points of improvements were identified, and
Antony committed to improve the library accordingly. The main concerns
were:

 - Definition of the type concept the library can work with
 - Clarification of the flat / precise use-cases
 - The presence of global operators
 - The way output formatting is defined
 - Dropping "Reflection" from the name (this is already reflected in the docs)

Antony plans to:

 - Remove Flat reflection
 - Remove global_ops
 - Add more examples to the docs, introduce terms in a cleaner manner
 - Improve the reference section
 - Take another look at the pfr::ops and macro for operators

After all these changes have been implemented, Antony would really
like to have a mini-review, regardless that the library is already
ACCEPTed, further confirming his high standards.

Good luck Antony, keep up the good work!

Benedek
review wizard