Re: Requesting feedback on boost::algorithm::is_clamped

From: Ivan Matek (libbooze_at_[hidden])
Date: 2021-08-29 21:23:41

On Mon, Aug 23, 2021 at 4:47 PM Vinnie Falco <vinnie.falco_at_[hidden]> wrote:

> On Fri, Aug 20, 2021 at 12:56 PM Ivan Matek via Boost
> <boost_at_[hidden]> wrote:
> > I would like to  get feedback from 5-10 other professional
> > developers from diverse backgrounds.
>
> Well I'm first generation Italian-American and politically
> conservative.

Explains why you prefer to standardize ASIO instead of libunifex ;)

Anyway, I left some comments on your pull request.
>
> Thank you, I have resolved the ones I knew how to resolve(technical ones),
most of unresolved are just awaiting resolve from you if you agree with my
reply.
I have no idea what to do about copyright so that remains open.

Sorry for lag, was busy during past week.

I have a few questions about working in boost.

   1. From what I can see b2 does not work when I just fork and clone
   algorithm repo. 😞 I cloned modular boost and b2 works ok there, but I did
   not figure out how to point algorithm submodule in modular-boost to my
   algorithm forked boost/algorithm. Does somebody knows how to make this
   workflow nicer? Now I am manually c/p stuff from algorithm fork to modular
   boost submodule directory and running b2(for tests) from there.
   2. Does somebody know how to tell b2 to use certain C++
   standard(equivalent  of --std= for clang/gcc  or /std: for msvc)?
   3. Is Marshall the only person that can approve changes in algorithm, or
   is there some OWNERS file I can look up to for who to ping for approval?