Re: Boost.URL: Something Wicked This Way Comes! (Was: Needs Review)

From: Vinnie Falco (vinnie.falco_at_[hidden])
Date: 2021-10-12 22:38:33

On Tue, Oct 12, 2021 at 3:28 PM Gavin Lambert via Boost
<boost_at_[hidden]> wrote:
> I note in the docs that there is also a set_encoded_path, which implies
> that set_path might be "unencoded", which might explain it -- but
> set_path has no documentation, so this is unclear.

The docs could use work as usual. Yes, there are two functions

set_encoded_path
set_path

For almost all functions that set a string, there is the "encoded"
version which requires a valid percent-encoded string, and the plain
version which accepts any string and then escapes the reserved
characters as needed.

> On an unrelated note, set_query_part seems wrong, it should have a
> leading question mark but the BNF specifies a leading hash.  Also it
> claims its input is an encoded string, which seems inconsistently named
> with set_encoded_query (which in turn mentions fragments in its docs,
> which also seems wrong).

Little bit of under-construction going on there, it will be resolved
today, thanks for looking!

Regards