Re: [Async] Naming land grab?

From: Andrzej Krzemienski (akrzemi1_at_[hidden])
Date: 2023-10-02 19:38:17

pon., 2 paź 2023 o 18:51 Vinnie Falco via Boost <boost_at_[hidden]>
napisał(a):

> On Mon, Oct 2, 2023 at 9:30 AM Niall Douglas via Boost
> <boost_at_[hidden]> wrote:
> > It's not too late for a review from you or Richard if you have strong
> > feelings that the library ought to be rejected?
>
> I don't have enough knowledge or experience with C++20 coroutines to
> be able to write a solid review but I believe there is a pattern of
> hastily written libraries being proposed for Boost which have
> reasonable implementations but not well thought out designs or
> extensive field testing. I am also concerned that coroutines are "in
> style" and there is a tendency for less seasoned reviewers to
> rubber-stamp anything related to them. However I lack sufficient
> evidence to lay this all out in a thoughtful way and thus I remain
> silent. If this library is accepted we might consider it an experiment
> to see if my concerns are needless. And allow sufficient time to pass
> before we review another hastily written library.
>

Thanks for saying this Vinnie. I share the concern.
I disagree with your decision, though, to refrain from the review because
you think you lack domain knowledge.
This is what the review question "how knowledgeable are you in the problem
domain" is for.
I fit into your description of a "less seasoned reviewer", so I just
mention this in the review, and still make my contribution.
This works as long as the reviews are not treated as votes.

Regards,
&rzej;

>
> Thanks
>
> _______________________________________________
> Unsubscribe & other changes:
> http://lists.boost.org/mailman/listinfo.cgi/boost
>