Re: [scope] Scope review starts on November 26th

From: Andrey Semashev (andrey.semashev_at_[hidden])
Date: 2023-12-01 11:11:52

On 12/1/23 11:17, Rainer Deyke via Boost wrote:
> On 30.11.23 18:49, Andrey Semashev via Boost wrote:
>> On 11/30/23 12:29, Дмитрий Архипов via Boost wrote:
>>> 6. include/boost/scope/detail/is_not_like.hpp: no human readable
>>> explanation of what this type-trait is supposed to do.
>>
>> It tests whether the left-hand type is not an instantiation of the
>> right-hand template.
> 
> Have you considered inverting this test?  I consider negative conditions
> in identifiers a code smell because they tend to lead to confusing
> double negatives.  !is_like reads as clearly to me as is_not_like, but
> !is_not_like reads much worse than is_like.

Everywhere in the library, it is needed to test that the type is *not*
like the template.  Making the type trait positive would require adding
detail::negation wrapper, i.e. adding one more template instantiation.