Re: Boost.Charconv review runs January 15th - 25th, 2024

From: Peter Dimov (pdimov_at_[hidden])
Date: 2024-01-25 17:57:14

John Maddock wrote:
> On the specifics: I agree with the comment about the constants in the headers,
> while these could hidden inside inline functions (which would then presumably
> get merged at link time), I see no good reason not to declare them extern and
> move to a .cpp file, given that we have separate source anyway.

I haven't looked at the specific constants in question, but if they are used by
the constexpr integral functions, you can't put them into a .cpp file.