Re: Should boost::core::string_view be made public?

From: Peter Dimov (pdimov_at_[hidden])
Date: 2024-02-08 16:24:45

Andrey Semashev wrote:
> This implies that the API only works with one character type, which is not
> always the case, as shown in Boost.Log.

It implies that if you want to accept e.g. wchar_t, you need a separate overload.

> Template interface parity is useful in cases like this:
> 
> https://github.com/boostorg/container/blob/6e697d796897b32b471b4f0740dcaa03d8ee57cc/include/boost/container/string.hpp#L685-L691
> 
> https://github.com/boostorg/container/blob/6e697d796897b32b471b4f0740dcaa03d8ee57cc/include/boost/container/string.hpp#L2314-L2316

This accepts vector<T, A>, but this might be considered a feature. :-)