Re: [release[ Boost 1.86.0 Beta 1 Release Candidate is available

From: Andrey Semashev (andrey.semashev_at_[hidden])
Date: 2024-07-11 22:45:08

On 7/12/24 01:16, Tom Kent via Boost wrote:
> On Thu, Jul 11, 2024 at 1:51 PM Marshall Clow via Boost <
> boost_at_[hidden]> wrote:
> 
>> Available at: https://archives.boost.io/beta/1.86.0.beta1/source/
>>
>> The SHA256 checksums are as follows:
>>
>> 90be7ebbaf1c81a849791eb0f49d05a9ec7dbd0ec98b974dfe31d44d811e8298
>> boost_1_86_0_b1_rc1.7z
>> 543ca3b743250a8b24b25c71209cf911c35613910e78a320835c21c053212ef2
>> boost_1_86_0_b1_rc1.tar.gz
>> 1bf831ed717fa3e01db6c1f104b95f5a6a8d098a4cc9e61fa6eb81969c78645f
>> boost_1_86_0_b1_rc1.tar.bz2
>> f739f8761bee6006c60a39fd21ed80b7b0a681c9ed448d1ae1bb28d8d8a69659
>> boost_1_86_0_b1_rc1.zip
>>
>>
>> As always, the release managers would appreciate it if you download the
>> candidate of your choice and give building it a try. Please report both
>> success and failure, and anything else that is noteworthy.
>>
>> -- The Release Managers
>>
> 
> We had some failures on windows, enough that we should probably have
> another RC to fix them.
> 
> Here's one example with msvc-14.0
> compile-c-c++
> D:\RB\bin.v2\boost\bin.v2\libs\process\build\msvc-14.0\release\x86_32\link-static\runtime-link-static\threading-multi\ext\cmd.obj
> cmd.cpp
> Please define _WIN32_WINNT or _WIN32_WINDOWS appropriately. For example:
> - add -D_WIN32_WINNT=0x0601 to the compiler command line; or
> - add _WIN32_WINNT=0x0601 to your project's Preprocessor Definitions.
> Assuming _WIN32_WINNT=0x0601 (i.e. Windows 7 target).
> .\boost/process/v2/detail/environment_win.hpp(63): error C3250: 'itrs':
> declaration is not allowed in 'constexpr' function body

The problematic function is here:

https://github.com/boostorg/process/blob/2c372461e8ab49fde18bff6c3c5e47b721d70383/include/boost/process/v2/detail/environment_win.hpp#L60-L70

It is marked with BOOST_CONSTEXPR, but it clearly requires
BOOST_CXX14_CONSTEXPR. The same goes for a few other functions in this
header.

> A link error with msvc-14.3 (similar ones for msvc-14.1 and msvc-14.2):

It seems, Boost.Process is missing linking with shell32, user32 and
ntdll in its Jamfile and CMakeLists.txt. Maybe with other libraries as
well. At least, I don't see where they are being linked.