Re: [release[ Boost 1.86.0 Beta 1 Release Candidate is available

From: Marshall Clow (mclow.lists_at_[hidden])
Date: 2024-07-22 23:58:55

On Jul 11, 2024, at 6:10 PM, Klemens Morgenstern via Boost <boost_at_[hidden]> wrote:
> 
> On Fri, Jul 12, 2024 at 6:49 AM Peter Dimov via Boost
> <boost_at_[hidden]> wrote:
>> 
>> Andrey Semashev wrote:
>>>> A link error with msvc-14.3 (similar ones for msvc-14.1 and msvc-14.2):
>>> 
>>> It seems, Boost.Process is missing linking with shell32, user32 and ntdll in its
>>> Jamfile and CMakeLists.txt. Maybe with other libraries as well. At least, I don't
>>> see where they are being linked.
> 
> Sorry, I missed that.
> 
>> 
>> Klemens added ntdll to CMakeLists.txt:
>> 
>> https://github.com/boostorg/process/commit/2c372461e8ab49fde18bff6c3c5e47b721d70383
>> 
>> build/Jamfile, however, doesn't seem to have it.
>> 
>> 
> 
> I added proper linking on develop now, fixed the constexpr and another
> bug. See the last three commits:
> https://github.com/boostorg/process/commits/develop/
> 
> Can I merge the three fixes into master?

Yes, please do.

— Marshall