Boost logo

Boost :

From: hermann_at_[hidden]
Date: 2024-10-07 19:26:11


5 days ago I created my first PR:
"new planar_vertex_six_coloring() algorithm with examples, tests and
doc"
https://github.com/boostorg/graph/pull/387

CI helped me to fix things I was responsible for.
But after that CI still fails in code I am not responsible for.

 From release notes:
https://www.boost.org/users/history/version_1_86_0.html

"...Graph:

     Major update: C++14 is the new minimum standard; this was partly
dictated by dependencies (at least to C++11) and partly by choice. If
you require support for an older standard, please contact the
maintainer.
..."

Somebody (who?) forgot to tell CI that minimum requirement.

Example error caused by this:

gcc.compile.c++
../../../bin.v2/libs/graph/test/gursoy_atun_layout_test.test/gcc-5/debug/x86_64/cxxstd-11-iso/threading-multi/visibility-hidden/gursoy_atun_layout_test.o
In file included from ../../../boost/math/constants/constants.hpp:11:0,
                  from ../../../boost/graph/topology.hpp:16,
                  from ../../../boost/graph/gursoy_atun_layout.hpp:34,
                  from gursoy_atun_layout_test.cpp:10:
../../../boost/math/tools/config.hpp:28:6: warning: #warning "Boost.Math
requires C++14" [-Wcpp]
  # warning "Boost.Math requires C++14"
       ^
In file included from ../../../boost/math/tools/mp.hpp:15:0,
                  from ../../../boost/math/policies/policy.hpp:11,
                  from ../../../boost/math/constants/constants.hpp:16,
                  from ../../../boost/graph/topology.hpp:16,
                  from ../../../boost/graph/gursoy_atun_layout.hpp:34,
                  from gursoy_atun_layout_test.cpp:10:
../../../boost/math/tools/type_traits.hpp:208:12: error: 'std::is_final'
has not been declared
  using std::is_final;

Since this is my first PR, will there be someone helping me in PR 387?

Who owns CI?

Can issues be created against CI?

Or do I understand this completely wrong?

Regards,

Hermann.


Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk