async-mqtt5 is CONDITIONALLY ACCEPTED

From: Klemens Morgenstern (klemensdavidmorgenstern_at_[hidden])
Date: 2024-10-30 01:01:27

Hi all,

thanks to everyone participating in the review! I really want to
express my appreciation to the reviewers, especially those who
invested multiple hours if not days to review this library: thank you
Vinnie, Ruben, Mohammad and Marcelo.

I interpreted Darylls review as a "weak rejection", but since that
doesn't exist in the formal review process I'll count it as a
rejection. Leaving the recommendations at

1 ACCEPT
3 CONDITIONAL ACCEPT
2 REJECT

The actual conditions for acceptance are:

1. Correct usage of the executor. It is an asio contract that the
async operation always completes on the associated executor and mqtt5
should follow this.
2. Add logging/reporting facilities. A user should be able to follow
what is happening internally and ideally react to it, especially
concerning reconnects.

I also recommend the authors to review all the comments, including the
rejections (Daryll's review had interesting details) and non-review
comments such as from Peter Turcan.

I would also advise that inclusion in boost is usually a time to
change the name, because the library now gains the boost. prefix. I.e.
boost.async-mqtt5 might be a bit cumbersome.
Also note that there is no time requirement to include this library in
boost in the next release.

Thanks again to everyone participating in the review and to Ivica &
Mireo for their submission.