Re: Formal Review Retrospective

From: Klemens Morgenstern (klemensdavidmorgenstern_at_[hidden])
Date: 2024-11-09 23:33:33

On Sun, Nov 10, 2024, 2:31 AM Vinnie Falco via Boost <boost_at_[hidden]>
wrote:

> Ironically, a robust discussion regarding the review process and the usage
> of Slack is now taking place... on Slack.
>
> Arnaud made this suggestion which I am reposting here:
>
> "... formalizing a "Retrospective" phase as an actual part of the Formal
> Review could be key in avoiding criticism against the process to leak into
> criticism against the proposed library."
>
> I think this is a great idea. After each formal review result is announced,
> there is a new "retrospective" thread started which allows the community to
> reply and weigh in on how they thought the review was conducted. This
> actually happened organically in the last review of async-mqtt5 and I think
> it could be enhanced if the review wizard or review manager had
> pre-emptively started a retrospective thread where the replies could be
> accumulated. The subject line could for example be "[async-mqtt5] Review
> Retrospective"
>
> What do you think?
>

NO. The review is over with the announcement of the result. IF you add an
official discussion thread you will end up with a review of the review and
no final decision will ever be accepted.

The second guessing without serious reason needs to stop not be encouraged.
It hurts the review process.
Serious issues are to be brought up with the review wizards off-list.
Criticism can be send to the RM off-list as well.

If you want to discuss a past review it needs to happen after enough time
has passed, so it doesnt turn into a second round of reviews. We could
maybe discuss the "reviews of the past year" every december or something
like that.