Re: [review] [sqlite]

From: Klemens Morgenstern (klemensdavidmorgenstern_at_[hidden])
Date: 2024-11-17 00:42:49

> Happy to begin my first review of a Boost library ! Thanks to the author
for this opportunity - and the lib ;)
>
> I've had some tiny problems compiling and running the tests with Apple
Clang (14 and 16). It seems linking to boost_url was missing so I had to
edit the CMakelists.txt. I don't know if it's a mistake from my side or an
edge-case for the build system, but anyway now that it builds I can not
find how to have the tests pass:

That was my mistake, I wrote that before url was a compiled lib and didn't
add the examples to CI.

>
> 1/1 Test #2: boost_test_extension_simple_scalar ...***Failed    0.02 sec
> Parse error near line 1: no such function: load_extension
>   SELECT load_extension('./simple_scalar');
>
> I would understand the author wants to avoid the rabbit hole of covering
"how to build and run for every possible system", but having at least some
indications in the docs could helpful ! :D
>

This looks like load_extensions is disabled in your sqlite instance. Can
you check by typing `.dbconfig` in the sqlite3 cli?

```
klemens_at_fedora:~$ sqlite3
SQLite version 3.46.1 2024-08-13 09:16:08
Enter ".help" for usage hints.
Connected to a transient in-memory database.
Use ".open FILENAME" to reopen on a persistent database.
sqlite> .dbconfig
          defensive on
            dqs_ddl off
            dqs_dml off
        enable_fkey off
        enable_qpsg off
     enable_trigger on
        enable_view on
     fts3_tokenizer off
 legacy_alter_table off
 legacy_file_format off
     load_extension on
   no_ckpt_on_close off
     reset_database off
  reverse_scanorder off
    stmt_scanstatus off
        trigger_eqp off
     trusted_schema off
    writable_schema off
sqlite>
```

See the `load_extension` line.

If it's false the test just won't work; I will need to add a workaround for
this either way.

> It feels a bit weird to ask such frivolity on the ML, thanks for your
patience,

There's nothing frivolous about your question.