Re: Formal review request for Hash2

From: Matt Borland (matt_at_[hidden])
Date: 2024-12-02 20:24:16

> I'd like to request a formal review for the Hash2 library
> 

> https://github.com/pdimov/hash2
> https://pdimov.github.io/hash2/
> 

> (by Christian Mazakas and myself.)
> 

> The library implements an extensible framework for implementing
> hashing algorithms that can support user-defined types. Its structure
> is largely based on the paper "Types don’t know #" by Howard Hinnant,
> Vinnie Falco and John Bytheway.
> 

> https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n3980.html
> 

> We're looking for a review manager.
> 

> Comments and questions are welcome; you don't need to wait for the
> review.
> 

I will endorse the review of the library, and volunteer as the review manager. Since Peter is the lead author (383 commits to 39 for Christian at time of writing), I don't see a real conflict of interest here despite Christian and I both being C++Alliance Employees. 

In case someone else was going to ask I previously asked about SHA3 support. Peter's response on Slack was "this library wasn't really supposed to be a repository of cryptographic hashes, we had to have some to prove that they work in the framework". I thought this was fair and did not push the issue further.

Peter also mentioned he would like to review the library soon, and December 7-15 seems feasible. I have no qualms with this time slot assuming sufficient reviewers are available. 

Matt