Re: Formal review request for Hash2

From: Ivan Matek (libbooze_at_[hidden])
Date: 2024-12-03 11:47:28

On Tue, Dec 3, 2024 at 2:56 AM Peter Dimov <pdimov_at_[hidden]> wrote:

> Ivan Matek wrote:
>  If you find yourself invoking
> hash_append with {} repeatedly, something is probably not right.
>
> where f is your flavor argument.
>

Yes, but then again I am passing f multiple times. I don't want it to sound
like I am making a big deal out of this, I can just do something like(and I
actually use this idiom a lot)
const auto append = [&] (const auto& val){hash_append (h, f, val);}
and use that "partially applied" helper, in case I actually need to do
hash_append
multiple times.
I just thought it would be nice to add something for beginners and to save
typing since docs recommend default_flavor.

Also I know bike-shedding about names is not  fun, but did you consider
naming it native_flavor? Might help people that are familiar with
std::endian enums learn library better.