Re: [hash2][review] Early review (due to holidays)

From: Claudio DeSouza (cdesouza_at_[hidden])
Date: 2024-12-05 13:12:23

>
>
> What is the practical advantage of using span (of any provider) over the
> traditional pointer+size? I emphasize the "practical" part, as opposed
> to any personal preference to "modern-ness", code style or anything like
> that.
>
>
Like I explained in my original review, there is now a new type of
program analysis guarded behind `-Wunsafe-buffers-usage` that this library
would greatly benefit from, if it were spanified. The warning itself is
opt-in to users. In the end of the day, this is about removing the chance
of certain categories of mistakes around the use of pointers, while
improving readability.