Re: [hash2][review] Early review (due to holidays)

From: Peter Dimov (pdimov_at_[hidden])
Date: 2024-12-06 18:01:46

Andrey Semashev wrote:
> On 12/6/24 20:52, Peter Dimov via Boost wrote:
> > Andrey Semashev wrote:
> >
> >> I don't trust the optimizer. Because it failed me more than once.
> >
> > That's not the point.
> >
> > The point is to make life easier for the optimizer, by giving it more
> > information to work with (in the form of the fixed extent).
> 
> I've already relieved it from work by not writing the unnecessary checks. :)

Sure, but you also didn't write the necessary checks that would have
caught a bug where you accidentally read past the end of the packet
due to a bad copy and paste.