Re: [hash2] Formal Review Begins

From: Peter Dimov (pdimov_at_[hidden])
Date: 2024-12-10 00:30:55

Zach Laine wrote:
> Why define your own endian?  You already have an external dependency it
> seems, on boost::container_hash, so why not use the logic and constants from
> Boost.Endian?

Endian would be an avoidable dependency, and people don't like those.

ContainerHash is different because the reason to depend on it is to pick up
user specializations of its traits. If you specialize ContainerHash's traits, it's
exceedingly likely that you want the same specializations for Hash2, and it's
friendlier to not make users specialize the same trait twice, as would have
happened if I duplicated them.