Re: [hash2] Formal Review Begins

From: Peter Dimov (pdimov_at_[hidden])
Date: 2024-12-10 00:39:15

Zach Laine wrote:
> Also, even if you don't change any of the names above, please don't use the
> phrase "sized_range", since we now have a std::ranges concept with that
> name that means something substantially different

That thought has occurred to me, but I never came up with a replacement
name that I was happy with.

> (std::ranges::sized_range requires std::ranges::size(x), for instance, where
> yours does not).

If we add overloads for the _range functions that actually take ranges
and not iterator pairs, the hash_append_sized_range function will however
require and use r.size(), instead of taking the iterator distance.