Re: Decimal: Formal review begins

From: Peter Dimov (pdimov_at_[hidden])
Date: 2025-01-21 17:48:16

Some random observations:

https://github.com/cppalliance/decimal/blob/069c26a111b33123e6ce5c34b4bb007762b32155/include/boost/decimal/decimal64_fast.hpp#L49

The class doesn't need to be marked as EXPORT, because
all its members are constexpr (or templated), and hence,
nothing is actually exported.

https://github.com/cppalliance/decimal/blob/069c26a111b33123e6ce5c34b4bb007762b32155/include/boost/decimal/decimal64_fast.hpp#L33-L35

The special inf value is higher than the special NaN values,
which causes isnan() to perform a biased compare

https://godbolt.org/z/78P73r986

instead of a straight one

https://godbolt.org/z/ebr3EsxWf

(I've changed the exponent type here to uint16_t to avoid
the pessimization identified earlier.)