Re: Decimal Review Result and Summary.

From: Ivan Matek (libbooze_at_[hidden])
Date: 2025-02-02 17:39:42

On Sat, Feb 1, 2025 at 7:36 PM John Maddock via Boost <boost_at_[hidden]>
wrote:

> First off I'd like to thank Matt and Chris for submitting the library
> for review, and for all the reviewers who submitted comments.  My
> apologies for not posting this sooner, but this has been a difficult
> review to reach a definite result on.
>

Big thank you to you and the authors for the work.

>
> SETTLED ISSUES
> ~~~~~~~~~~

> One reviewer suggested using CLZ in num_digits, but this has been
> checked and is slower (a comment in the source to that effect would be
> welcome.  Note that std::lower_bound is not constexpr until C++26.
>

For clz I would be interested to see the benchmarks since I know some
famous libraries used the clz trick so I would be  curios to learn how it
can be slower.

That one reviewer forgot that lower_bound is not constexpr in C++14, my
apologies. But it is constexpr in C++20, not C++26 so one more reason for
authors to bump the required version. ;)
https://godbolt.org/z/qf8GE8WYv