Re: [Bloom] Some questions

From: Steven Watanabe (watanabesj_at_[hidden])
Date: 2025-05-20 00:09:24

AMDG

On 5/19/25 1:01 PM, Ivan Matek via Boost wrote:
> On Mon, May 19, 2025 at 8:27 PM Joaquin M López Muñoz via Boost <
> boost_at_[hidden]> wrote:
> 
>>> It is IDE clang-tidy warning, not sure compiler matters.
>>>
>> https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-inline-specifier.html
>>>
>>
>>
>> Could you please check if adding this comment to the offending lines
>>
>> /* NOLINT(readability-redundant-inline-specifier) */
>>
>> makes the warnings go away? If so, I'd happily accept a PR with
>> that change. Thank you!
>>
> 
> I am now a bit confused :)
> I believe warning is correct, why not change the code instead of
> suppressing the warning?

What do you mean by correct? The warning does not indicate a problem in 
the code, and whether it is more or less readable is very subjective. It 
seems like a pretty pointless warning to me. Even if you care about such 
things, you really shouldn't be applying it to any code other than your own.

In Christ,
Steven Watanabe