Re: [Bloom] review starts on 13th of May

From: Peter Dimov (pdimov_at_[hidden])
Date: 2025-05-21 18:16:36

Joaquin M López Muñoz wrote:
> > * It looks like the tests are not being built from CMake. Having
> > "if(BUILD_TESTING AND EXISTS
> > "${CMAKE_CURRENT_SOURCE_DIR}/test/CMakeLists.txt")" in the main
> > CMakeLists.txt may trick the reader into thinking they are, but there
> > is no test/CMakeLists.txt. I understand that this is what's generated
> > by default by boostdep --cmake, but I'd advise either to add a
> > test/CMakeLists.txt (preferable) or removing the if statement
> > altogether.
> 
> I depend on others' kindness for that as my knowledge of CMake
> is embarrasingly limited. Will ask for help to do it (if you know how to do
> it and would like to submit a PR, be my guest!)

You need to simplify your test/Jamfile, instead of

test-suite "bloom" :
    [ run test_array.cpp        ]
    [ run test_capacity.cpp     ]
    [ run test_combination.cpp  ]
    [ run test_comparison.cpp   ]
    [ run test_construction.cpp ]
    [ run test_fpr.cpp          ]
    [ run test_insertion.cpp    ]
    ;

have just

run test_array.cpp ;
run test_capacity.cpp ;
run test_combination.cpp ;
run test_comparison.cpp ;
run test_construction.cpp ;
run test_fpr.cpp ;
run test_insertion.cpp ;

and then the "generic" test/CMakeLists.txt that uses boost_test_jamfile
which you can lift from somewhere else will work with minimal changes.