Re: [Boost-docs] [boostbook][PATCH] member classes in synopsis

Subject: Re: [Boost-docs] [boostbook][PATCH] member classes in synopsis
From: Frank Mori Hess (frank.hess_at_[hidden])
Date: 2009-06-01 15:21:33

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 01 June 2009, Daniel James wrote:
> 2009/5/29 Frank Mori Hess <frank.hess_at_[hidden]>:
> > The attached patch attempts to make member classes look a little better
> > in the parent class synopsis.  If noone objects, I'll apply it to trunk
> > sometime next week.
>
> I think the patch looks okay, are there any examples of documentation
> that will change? 

I'm not sure.  It will change the signals2::signal and slot synopses, once I 
check in the changes that add arg member classes to their docs (I'll try to 
do that today).  The problem was the member class ran together with the 
static constants, like:

// static constants
static const int arity = N;
template<unsigned n> class arg
{
public:
        typedef Tn type;
};

And the patched version adds a blank line and comment between them:

// static constants
static const int arity = N;

// member classes/structs/unions
template<unsigned n> class arg
{
public:
        typedef Tn type;
};

> Also, can you indent the existing 
> <xsl:apply-templates> tag, since it's now in the if tag.

Sure.  Actually it just looks that way because I generated the patch with "svn 
diff -x -w" to try and make it clearer which parts I was really changing.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkoj8f4ACgkQ5vihyNWuA4Wi9QCfQ5uTnIwDZQhRF0scIaoC5H/o
96oAoJpD08J3du+iG4QatUK6Iml4t8re
=uxwE
-----END PGP SIGNATURE-----