Re: [Boost-docs] [BoostBook] Support for SVN fixed-length $Date$ keyword

Subject: Re: [Boost-docs] [BoostBook] Support for SVN fixed-length $Date$ keyword
From: Robert Kawulak (robert.kawulak_at_[hidden])
Date: 2013-07-13 11:40:25

> From: Daniel James
> I'm not really familiar with this part of the code. Just looking at
> the existing code, I want to make some changes. I think I'll modify
> the calling code to check for '$Date:' first. Also, the code in
> html-help.xsl doesn't seem to be used, so that should just be deleted.
> If we ever want to add this to html-help.xsl then it should be from a
> shared implementation. But I can do all of that after your patch.

I was also wondering why the code is duplicated, but didn't want to touch more
than needed not to break something. ;)

> Regarding your patch, the "substring-after($text, ' ')" looks fragile
> to me, IIUC "substring-after($text, ': ')" should work and be a little
> better.

Good idea, I've changed that.

> Other than that, it seems fine.

I'm not familiar with the process and would be grateful for some clues - do I
patch the trunk only, or do I also do this in release branch?

Thanks and best regards,
Robert