Boost logo

Ublas :

From: Michael Stevens (mail_at_[hidden])
Date: 2005-02-10 03:57:09

Hi Toon, Hi Karl,

I was just committing some consistency fixes to Karl's _temporary_traits
mechanism. In particular "triangular" and "banded" removed the old typedef
but didn't define new traits. This was breaking my Bayes++ library. I think I
have now made all the '_adaptor' classes consistent.

I also added the comment
        // Replaced by _temporary_traits to avoid type requirements on M
infront of the commented out code. I really dislike seeing commented out code
without a reason. I never no if the code was accidentally committed with the
code commented out or if it had to go for a reason!

In the process of committing I see that a similar fix has already gone into
"triangular" version 1.45 so it is nice to see I was on the right track!

I am a bit confused regarding the new 'remove_const' logic in "triangular"
however. I have a couple of questions regarding this.
a) Why is it necessary? I don't see how the 'const'ness of M can prorogate
into _temporary_type.
If is is necessary
b) Is it only necessary for traingular_adaptors?
c) Should it not go into "temporary.hpp"

I have merged and committed leaving in the 'remove_const'


Michael Stevens Systems Engineering
Navigation Systems, Estimation  and
                 Bayesian Filtering