|
|
Ublas : |
Subject: Re: [ublas] Should/can I use GitHub to fix issue #7902 Division by scalar should use enable_if<>
From: Joaquim Duran (jduran.gm_at_[hidden])
Date: 2014-11-24 03:36:05
The issue with the procedure defined in
https://github.com/uBLAS/ublas/wiki is since version 1.57, modular
boost checkout an specific commit id from boostorg/ublas. That commit
id is not present in ublas/ublas so checkout process fails. This could
be the origin of the problem. This problem has a workarround, I'll
explain it when I comeback at home.
Joaquim Duran
2014-11-23 0:55 GMT+01:00 Sean Reilly <campreilly_at_[hidden]>:
> This is my first time contributing to boost, and I'm having some trouble
> getting started using the instructions on
> https://github.com/uBLAS/ublas/wiki. It appears that boost itself is having
> a problem with the boostrap process. Here is all that I'm doing to
> demonstrate this problem.
>
> git clone https://github.com/boostorg/boost modular-boost
> cd modular-boost/
> ./bootstrap.sh
>
> Responds with
>
> ./bootstrap.sh: line 188: ./tools/build/src/engine/build.sh: No such
> file or directory
>
> and it turns out that the ./tools/build directory is empty. As the man
> says, "Gee that don't look right."
>
> Heard of anyone else having this issue with the boost repository? Can I get
> around this my just stealing the contents from the Boost 1.57 distribution?
>
> Sean
>
>
> On Thu, Nov 20, 2014 at 4:16 PM, Nasos Iliopoulos <nasos_i_at_[hidden]>
> wrote:
>>
>> Sean,
>> please fork from:
>> https://github.com/uBLAS/ublas/tree/develop
>>
>> and not from the the boostorg repository.
>>
>> General guidelines:
>> https://github.com/uBLAS/ublas/wiki
>>
>>
>> -Nasos
>>
>>
>> On 11/20/2014 02:42 PM, David Bellot wrote:
>>
>> Hi Sean,
>>
>> yes, for any bug fix, please use Github. For the project in your own
>> account and checkout branch develop.
>> When you submit your pull request, it must be for branch develop.
>>
>> We're not using the old repository anymore.
>>
>> Thanks for contributing,
>> David
>>
>>
>> On Thu, Nov 20, 2014 at 5:35 PM, Sean Reilly <campreilly_at_[hidden]> wrote:
>>>
>>> Background:
>>>
>>> I was looking at Boost 1.57 and noticed that my old 7902 bug was still in
>>> there.
>>>
>>> #7902: Bugs: Division by scalar should use enable_if<>
>>> (matrix_expression) (new)
>>> Bug #6511 added enable_if<> to file: vector_expression.hpp function:
>>> operator/( vector, scalar). The same feature needs to be add to
>>> matrix_expression's operator/( matrix, scalar). See attached e-mail By
>>> campreilly@… — 01/17/13 21:55:55
>>>
>>> This error is almost exactly the same as a previous bug that has already
>>> been fixed in vector_expression.hpp under issue 6511. But, I forgot to
>>> mention matrix_expression.hpp in that bug, perhaps because I'm a
>>> knucklehead.
>>>
>>> #6511: Bugs: Division by scalar should use enable_if<> (closed: fixed)
>>> file: vector_expression.hpp lines 1409 through 1417 function: operator/(
>>> vector, scalar) Should be using the enable_if<> macros just like the
>>> operator*() in lines 1397 through 1407 (just above it). Doing so allows
>>> further overloading ... By Sean Reilly <campreilly@…> — 02/01/12 15:38:09
>>>
>>> Question:
>>>
>>> It is a simple one line fix, but I haven't kept up with the updated
>>> development and delivery process. Would you like me to fork GitHub, fix it,
>>> and issue a pull request. Is that how we are handling these kinds of
>>> changes?
>>>
>>> Sean Reilly
>>>
>>> _______________________________________________
>>> ublas mailing list
>>> ublas_at_[hidden]
>>> http://lists.boost.org/mailman/listinfo.cgi/ublas
>>> Sent to: david.bellot_at_[hidden]
>>
>>
>>
>>
>> _______________________________________________
>> ublas mailing list
>> ublas_at_[hidden]
>> http://lists.boost.org/mailman/listinfo.cgi/ublas
>> Sent to: athanasios.iliopoulos.ctr.gr_at_[hidden]
>>
>>
>>
>> _______________________________________________
>> ublas mailing list
>> ublas_at_[hidden]
>> http://lists.boost.org/mailman/listinfo.cgi/ublas
>> Sent to: campreilly_at_[hidden]
>
>
>
> _______________________________________________
> ublas mailing list
> ublas_at_[hidden]
> http://lists.boost.org/mailman/listinfo.cgi/ublas
> Sent to: jduran.gm_at_[hidden]