November 2007 - Boost - lists.boost.org

** Unmerged changes from 1.34.1 - on your own
by David Abrahams 03 Nov '07

03 Nov '07

I'm going to stop posting notices about the files that probably need to be looked at. First of all, it's getting tedious and I'm making mistakes. Secondly, I'm afraid it will make some people complacent -- i.e., ********************************************************************* * Don't assume that just because I didn't post something about your * * library, there aren't 1.34 changes you need to merge. * ********************************************************************* We spent a long time getting 1.34.1 right and I'm very concerned about backsliding from that state of quality. I don't know how we're going to verify that we've done the merging process correctly, so all I can ask is that everyone be extremely meticulous and look at all the files you touched on the branch. I can get a list of all the files I touched with the following incantation: $ svn log -v https://svn.boost.org/svn/boost/branches/RC_1_34_0/boost \ | sed -n '/(dave|david_abrahams)/,/-----$/ p' \ | grep RC_1_34_0 \ | sed -e 's/^ *[A-Z] *//' \ | sort I stupidly changed my userid from david_abrahams to dave when we moved to svn, not thinking how it would mess things up; that accounts for my use of '(dave|david_abrahams).' That's just future-proofing, since we switched to svn after the 1.34 release branch was closed -- what really counts is your SourceForge userid. Thanks for giving this your attention. -- Dave Abrahams Boost Consulting http://www.boost-consulting.com

1 0

MPI, interprocess, intrusive missing from doc/Jamfile.v2
by David Abrahams 03 Nov '07

03 Nov '07

These appear to be unmerged changes from RC_1_34_0 -- Dave Abrahams Boost Consulting http://www.boost-consulting.com

2 2

[system] patch for access violation on FormatMessage failure
by David Deakins 03 Nov '07

03 Nov '07

I ran across a case this morning where the FormatMessage Win32 call in boost::system_error_category::message() fails (the error message table did not have an entry for the error code that was passed). Unfortunately, when this happens lpMsgBuf is not initialized to anything and trying to use it can result in an access violation. The attached patch adds checks to catch situations where FormatMessage fails. Thanks, -Dave Index: error_code.cpp =================================================================== --- error_code.cpp (revision 40686) +++ error_code.cpp (working copy) @@ -347,7 +347,7 @@ { # ifndef BOOST_NO_ANSI_APIS LPVOID lpMsgBuf; - ::FormatMessageA( + DWORD retval = ::FormatMessageA( FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS, @@ -358,11 +358,14 @@ 0, NULL ); + if (retval == 0) + return std::string(); + std::string str( static_cast<LPCSTR>(lpMsgBuf) ); ::LocalFree( lpMsgBuf ); // free the buffer # else // WinCE workaround LPVOID lpMsgBuf; - ::FormatMessageW( + DWORD retval = ::FormatMessageW( FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS, @@ -373,10 +376,13 @@ 0, NULL ); + if (retval == 0) + return std::string(); int num_chars = (wcslen( static_cast<LPCWSTR>(lpMsgBuf) ) + 1) * 2; LPSTR narrow_buffer = (LPSTR)_alloca( num_chars ); - ::WideCharToMultiByte(CP_ACP, 0, static_cast<LPCWSTR>(lpMsgBuf), -1, narrow_buffer, num_chars, NULL, NULL); + if (::WideCharToMultiByte(CP_ACP, 0, static_cast<LPCWSTR>(lpMsgBuf), -1, narrow_buffer, num_chars, NULL, NULL) == 0) + return std::string(); std::string str( narrow_buffer ); ::LocalFree( lpMsgBuf ); // free the buffer

2 1

libs/optional/test/optional_test.cpp
by David Abrahams 03 Nov '07

03 Nov '07

Please inspect for unmerged changes -- Dave Abrahams Boost Consulting http://www.boost-consulting.com

1 1

libs/optional/doc/optional.html
by David Abrahams 03 Nov '07

03 Nov '07

please inspect for unmerged changes -- Dave Abrahams Boost Consulting http://www.boost-consulting.com

1 0

string_algorithm: several doc edits, one doxygen source unmerged
by David Abrahams 02 Nov '07

02 Nov '07

Please check these out to make sure all the right 1.34.0 changes have been merged to trunk. -- Dave Abrahams Boost Consulting http://www.boost-consulting.com

2 1

Broken revision in SVN (39791)
by Caleb Epstein 02 Nov '07

02 Nov '07

I'm trying to use "SVK" to keep a local mirror of the Boost SVN Repository on my home machine. Things have worked great until my most recent attempt to "svk sync" on my mirror. The operation crapped out at revision 39791. Try running: svn log -r 39791 -v http://svn.boost.org/svn/boost/trunk/ You get a completely empty message. Similarly, svn diff -r 39790:39791 http://svn.boost.org/svn/boost/trunk/ is empty. This is not usual with SVN. Any idea whats going on here? Perhaps some filesystem corruption on the server? -- Caleb Epstein

3 3

Status of libs/iterator/doc/quickbook?
by David Abrahams 02 Nov '07

02 Nov '07

Is that stuff all ready for primetime? Should I delete the HTML from the source repo? -- Dave Abrahams Boost Consulting http://www.boost-consulting.com

1 0

Graph library docs: suspicious unmerged changes
by David Abrahams 02 Nov '07

02 Nov '07

These are mostly license/copyright problems, but there are a few others worth examining. -- Dave Abrahams Boost Consulting http://www.boost-consulting.com

1 0

libs/function/doc unmerged copyrights?
by David Abrahams 02 Nov '07

02 Nov '07

Index: doc/history.xml =================================================================== --- doc/history.xml (revision 40672) +++ doc/history.xml (working copy) @@ -1,4 +1,11 @@ <?xml version="1.0" encoding="utf-8"?> + <!DOCTYPE library PUBLIC "-//Boost//DTD BoostBook XML V1.0//EN" "http://www.boost.org/tools/boostbook/dtd/boostbook.dtd"> <section id="function.history" last-revision="$Date$"> Index: doc/tests.xml =================================================================== --- doc/tests.xml (revision 40672) +++ doc/tests.xml (working copy) @@ -1,4 +1,11 @@ <?xml version="1.0" encoding="utf-8"?> + <!DOCTYPE library PUBLIC "-//Boost//DTD BoostBook XML V1.0//EN" "http://www.boost.org/tools/boostbook/dtd/boostbook.dtd"> <testsuite id="function.testsuite" last-revision="$Date$"> Index: doc/tutorial.xml =================================================================== --- doc/tutorial.xml (revision 40672) +++ doc/tutorial.xml (working copy) @@ -1,4 +1,11 @@ <?xml version="1.0" encoding="utf-8"?> + <!DOCTYPE library PUBLIC "-//Boost//DTD BoostBook XML V1.0//EN" "http://www.boost.org/tools/boostbook/dtd/boostbook.dtd"> <section xmlns:xi="http://www.w3.org/2001/XInclude" id="function.tutorial" Index: doc/faq.xml =================================================================== --- doc/faq.xml (revision 40672) +++ doc/faq.xml (working copy) @@ -1,4 +1,11 @@ <?xml version="1.0" encoding="utf-8"?> + <!DOCTYPE library PUBLIC "-//Boost//DTD BoostBook XML V1.0//EN" "http://www.boost.org/tools/boostbook/dtd/boostbook.dtd"> <section id="function.faq" last-revision="$Date$"> Index: doc/misc.xml =================================================================== --- doc/misc.xml (revision 40672) +++ doc/misc.xml (working copy) @@ -1,4 +1,11 @@ <?xml version="1.0" encoding="utf-8"?> + <!DOCTYPE library PUBLIC "-//Boost//DTD BoostBook XML V1.0//EN" "http://www.boost.org/tools/boostbook/dtd/boostbook.dtd"> <section id="function.misc" last-revision="$Date$"> Index: doc/Jamfile.v2 =================================================================== --- doc/Jamfile.v2 (revision 40672) +++ doc/Jamfile.v2 (working copy) @@ -1,3 +1,8 @@ +# Copyright (c) 2002 Douglas Gregor <doug.gregor -at- gmail.com> + +# Distributed under the Boost Software License, Version 1.0. +# (See accompanying file LICENSE_1_0.txt or copy at +# http://www.boost.org/LICENSE_1_0.txt) project boost/doc ; import boostbook : boostbook ; Index: doc/reference.xml =================================================================== --- doc/reference.xml (revision 40672) +++ doc/reference.xml (working copy) @@ -1,4 +1,11 @@ <?xml version="1.0" encoding="utf-8"?> + <!DOCTYPE library PUBLIC "-//Boost//DTD BoostBook XML V1.0//EN" "http://www.boost.org/tools/boostbook/dtd/boostbook.dtd"> Index: index.html =================================================================== --- index.html (revision 40672) +++ index.html (working copy) @@ -1,4 +1,11 @@ <html> + <head> <meta http-equiv="refresh" content="0; URL=../../doc/html/function.html"> </head> -- Dave Abrahams Boost Consulting http://www.boost-consulting.com

1 0