September 2009 - Boost - lists.boost.org

Re: [boost] Are warnings acceptable artifacts from builds?
by pete＠pcbartlett.com 09 Sep '09

09 Sep '09

On Wed 09/09/09 15:19 , Maciej Sobczak <prog(a)msobczak.com> wrote: > If a given user has a strict policy of > not > having *any* warnings during their build, then that policy is enough > to > prevent them from using Boost. I'm pretty sure that this scenario is > not > something that library authors would easily accept. > Regards, With gcc, we have chosen to include Boost using -i_system rather than -i so that /all/ Boost-generated warnings are suppressed, on the grounds that Boost developers know what they are doing and that all warnings are thus spurious. I'm interested if others think this approach is too cavalier.

2 1

Re: [boost] [warnings] Are warnings acceptable artifactsfrom builds?
by pete＠pcbartlett.com 09 Sep '09

09 Sep '09

"Stewart, Robert" <Robert.Stewart(a)sig.com> wrote: >I regularly code with two-up emacs buffers, 80 columns each. That approach also permits me to print source code -- which I do not infrequently -- >without hard to follow line breaks. Consequently, I like the 80 column limit and am frustrated by code that exceeds that limit. Printing landscape may ease your frustration somewhat.

1 0

Interest request for pointer+bit compression optimization
by vicente.botet 09 Sep '09

09 Sep '09

Hi, I have recently found in the blog of Joaquin the following optimization consisting in embed a bit into the representation of a pointer. Please read it, it is not too long (http://bannalia.blogspot.com/2008/11/optimizing-red-black-tree-color-bits.h…) I was wondering if it would be interesting to provide some generic template classes making easier this kind of optimization. We can define two templates (See below) template <typename E> struct bit_ref; template <typename T> struct pointer_ref; So instead of having enum color_type{red=false,black=true}; class rb_node { private: color_type color_; regular_rb_node_header* parent; color_type& color(){return color_;}? color_type color()const{return color_;}? rb_node*& parent(){return parent_;}? rb_node* parent() const{return parent_;} } we can compress the colot_type and the rb_node* as follows class rb_node { private: uintptr_type parentcolor_; public: bit_ref<color_type> color(){return bit_ref<color_type>(&parentcolor_);} color_type color()const{return bit_ref<color_type>(&parentcolor_);} pointer_ref<rb_node> parent(){return pointer_ref<rb_node>(&parentcolor_);} rb_node* parent() const {return pointer_ref<rb_node>(&parentcolor_);} }; Next follows the definition of the template classes template <typename E> struct bit_ref { bit_ref(uintptr_type* r_):r(r_){} operator E() const { return E(*r&uintptr_type(1)); } bit_ref& operator=(E c) { *r&=~uintptr_type(1); *r|=uintptr_type(c); return *this; } bit_ref& operator=(const bit_ref& x) { return operator=(x.operator T()); } private: uintptr_type* r; }; template <typename T> struct pointer_ref { pointer_ref(uintptr_type* r_):r(r_){} operator T*() const { return (T*)(void*)(*r&~uintptr_type(1)); } pointer_ref& operator=(T* p) { *r=((uintptr_type)(void*)p)|(*r&uintptr_type(1)); return *this; } pointer_ref& operator=(const pointer_ref& x) { return operator=(x.operator T*()); } pointer_ref operator->()const { return operator T*(); } private: uintptr_type* r; }; Thanks Joaquin for sharing simple things like this one, stable_vector and others in your Bannalia blog. _____________________ Vicente Juan Botet Escribá

12 27

Boost.CrashReport?
by Boris Schaeling 09 Sep '09

09 Sep '09

I'm looking for a C++ library which comes close to what I imagine to be the ideal crash reporting library Boost.CrashReport. :) Firefox seems to use google-breakpad but maybe some of you have been using other (C++?) libraries. Or did anyone start to work on something like Boost.CrashReport (not that I found anything in the vault)? I don't need a library to upload automatically a crash report to a website. But if an application crashs I want to tell a user to send me file X in directory Y to avoid explaining who Dr. Watson is or what 'ulimit -c' does. Boris

2 4

Boost.Swap docs missing mention of header!
by David Abrahams 09 Sep '09

09 Sep '09

http://www.boost.org/doc/libs/1_40_0/libs/utility/swap.html doesn't tell me what I need to include in order to use boost::swap. -- Dave Abrahams BoostPro Computing http://www.boostpro.com

4 4

[filesystem] Windows long paths (and also API differences)
by Adam Badura 09 Sep '09

09 Sep '09

In a simple test program I used create_directories with long path (longer then MAX_PATH being equal to 260 on my machine). ANSI version (for char) threw an exception but before reaching MAX_PATH (somewhere around 255 characters however I did not test exactly). UNICODE version (for wchar_t) created as many directories as it could (as many as would make ANSI version not throw) and skipped rest without throwing anything. This seems bad. Why is it so? And is the MAX_PATH file system limitation on Windows or is it just a limitation for some API functions? Also by the way I wanted to ask why signatures of many functions differ from the documentation. For example no function takes error code parameter and thus always throws on failure (excluding the above example...). In some places I would prefer to have that parameter instead. Also copy_file does not take the third parameter allowing it to do replacing. Why is it so? I am using Boost 1.39 (1.40 does not work for me somehow, when I try to use it it gives compilation errors as I already mentioned in a previous thread) and Visual Studio 2005 on Vista machine. Adam Badura

2 2

Re: [boost] [serialization] Linker errors in trunk
by Hartmut Kaiser 08 Sep '09

08 Sep '09

> Sorry, resending as it ended up on the wrong list... > > ----------------------------- > > Since the latest changes in trunk I'm seeing linker errors while > linking with the serialization library (VS2005 SP1, > boost_serialization-vc80-mt-gd-1_40.lib): > > runtime_support.obj : error LNK2001: unresolved external symbol > "__declspec(dllimport) public: __thiscall > boost::archive::archive_exception::archive_exception(enum > boost::archive::archive_exception::_exception_code,char const *,char > const *)" > (__imp_??0archive_exception@archive@boost@@QAE@W4_exception_code@012@PB > D1@Z) > > (note the leading underscore in _exception_code) > > Which is really strange as this symbol is the only missing one. > > OTOH, the library exports the symbol: > > boost::archive::archive_exception::archive_exception( > enum boost::archive::archive_exception::exception_code, > char const *,char const *); > > (note the missing underscore in exception_code) > > If I change the first parameter of the archive_exception constructor to > be a 'int' everything builds fine. Ok, I solved it. The MS header file excpt.h has a #define exception_code _exception_code which leads to problems if not consistently included. Doh! What a mess. The bottom line is, that archive_exception.cpp needs to be compiled with exactly the same windows headers included (excpt.h gets included by windows.h) as any sources including archive_exception.hpp, which is generally not possible to ensure. The only fail-proof way I could see is to always have #if defined(BOOST_WINDOWS) #include <excpt.h> #endif inside archive_exception.hpp, globally mapping exception_code to _exception_code. Patch attached. Ok to commit? Regards Hartmut

4 9

Re: [boost] [Boost.Function] How about parallel functions?
by Kasra 08 Sep '09

08 Sep '09

>> Hi, >> >> I required to call few functions is separate threads and use the >> results. However, the code for this looks really ugly, you have to create >> threads, then join the threads when ever you require the result of the >functions. >> >> So I have created a boost.parallel_function library that does this >> seamlessly just like invoking a normal function and it only joins the >> thread when the value of the function result type is required. Is this >> library of any interest to any one? >> >> Here is the a hello world example: >> >> #include <cstdlib> >> #include <limits> >> #include <boost/parallel_function.hpp> >> using namespace boost; >> >> int F0() >> { >> volatile int x = 0; >> for(int i=0; i<std::numeric_limits<int>::max()/1024; i++) >> x ^= std::rand(); >> return (int)x; >> } >> >> >> int F2(int y) >> { >> volatile int x = 0; >> for(int i=0; i<std::numeric_limits<int>::max()/512; i++) >> x ^= std::rand(); >> return (int)x ^ y; >> } >> >> int main() >> { >> typedef boost::parallel_function< void ( ) > f0_type; >> typedef boost::parallel_function< void (int) > f1_type; >> >> f0_type f0( &::F0 ); >> f1_type f1( &::F1 ); >> >> f0_type::result_type r0 = f0(); >> f1_type::result_type r1 = f1(32); >> >> // use r0 and r1 as if they are int >> r0 += 34; >> int value = r1 *= r0 + 452; >> >> std::cout << "Hello world " << value << std::endl; >> >> return 0; >> } > >The Boost.Task library should provides the features you need. > >int main() { > > boost::task::handle<int> f0 = boost::task:async(boost:task(F0),boost::task::new_thread()); > boost::task::handle<int> f1 = boost::task:async(boost:task(F1,32),boost::task::new_thread()); > int r0=f0.get(); > int r1=f1.get(); > > r0 += 34; > int value = r1 *= r0 + 452; > > std::cout << "Hello world " << value << std::endl; > > return 0; >} > >This library is under the review schedule and will be reviewed soon. I'm >interested on the details of your implementation to compare with >Boost.Task. It will be also useful if you can take a look to Boost.task and >try so see it provides every thing you need. > >Best, >Vicente I have taken a partial look at Boost.task, however, what I don't like about the syntax is the following: > int r0=f0.get(); > int r1=f1.get(); Current implementation (hack) would make 'f0' and 'f1' the same type 'int' (in this example). So the .get() part could be omitted altogether; which seems a lot like thread.join() call! Which is accomplished by a simple implicit conversion operator to the reference of the type. A little out of topic discussion, why is there an atomic library within task? because boost.thread has one (I think). Atomic library should be written so it becomes more coherent and reduces the code size. With Best Regards Mr. Kasra Nassiri Department of Mathematics & Computer Science Imperial College London

3 2

[Graph] 1.40 Static Link Issue
by Gordon Smith 07 Sep '09

07 Sep '09

There seems to be an unused bool in fruchterman_reingold.hpp: bool vertex_migration = false; Which will cause link errors if included in more than one statically linked library. Gordon.

2 1

Move notes
by David Abrahams 07 Sep '09

07 Sep '09

Hi Ion, A few things I noticed looking through move.hpp in the sandbox 1. you static_cast in one direction but reinterpret_cast in the other. Why? 2. I think move_iterator's operator-> return type is wrong; maybe make the pointer type be the underlying iterator type instead? 3. I think its operator[] can be wrong for some iterators. See http://www.boost.org/doc/libs/1_40_0/libs/iterator/doc/iterator_facade.html… 4. bool-valued traits should be derived from an MPL integral constant, e.g. template <class T> struct is_whatever : mpl::bool_< (some compile-time expression ) > {}; Cheers, -- Dave Abrahams BoostPro Computing http://www.boostpro.com

3 4

[optional] compatibility with arrays
by Craig Henderson 07 Sep '09

07 Sep '09

I am using boost::optional but have hit a problem with arrays. Using MSVC8, the definition boost::optional<char[R] > foo_; produces a compilation error: boost_1_39_0\boost/optional/optional.hpp(315) : error C2075: 'Target of operator new()' : array initialization needs curly braces boost_1_39_0\boost/optional/optional.hpp(314) : while compiling class template member function 'void boost::optional_detail::optional_base<T>::construct(const char (&))' with [ T=char [3] ] boost_1_39_0\boost/optional/optional.hpp(455) : see reference to class template instantiation 'boost::optional_detail::optional_base<T>' being compiled with [ T=char [3] ] There is no mention of non-arrays in the type requirements, so I don't know if this is specific to MSVC8, or a general/known problem? I have overcome the problem using boost::array boost::optional<boost::array<char,R> > foo_; Is there an opportunity to detect an array and substitute a boost::array for the given type? Thanks -- Craig Craig Henderson <http://craighenderson.co.uk/> http://www.craighenderson.co.uk http://www.siteupdatenotification.com

1 0

Re: [boost] [Boost.Function] How about parallel functions?
by Kasra 07 Sep '09

07 Sep '09

The example is fine thanks. However, it has syntax errors! more like typepos :D -- Kasra

1 0

Arbitrary precision arithmetic
by Scott Johnson 07 Sep '09

07 Sep '09

Greetings. This is my first post to the mailing list, so I'll try not to act stupid. :) The recent release of Boost (1.39.0), in the boost::rational library documentation, broadly hints at (and expresses a fond wish for) an arbitrary-precision integer ("bignum") library; however none currently exists within Boost. There are numerous such libraries out in the wild (many targeted towards C); though some of them are under incompatible licenses. (One interesting starting point would be libtommath, by Tom St. Denis; it appears to be a pretty robust and functional C library; which now has a C++ wrapper--albeit one that doesn't meet boost standards. It also contains numerous other useful number-theoretic functions, many of which appear to not be dependeing on the underlying bigint type. And it's in the public domain, or at least appears to be...) Searching through the mailing list, I've seen numerous references to creating such a thing, some of them dating back nearly ten years--but none yet seems to exist. This is something, I think, which would be Really Useful to add to boost. I wasn't able to locate any current boost project or proposal to create such a thing--though it's certainly possible I looked up the wrong keyword(s). So, my possibly impertinent newbie question: Is anyone (seriously) working on such a thing, for inclusion in boost? Are there any nasty (political) obstacles to such a thing being added? Thanks! -- engineer_scotty (no, not that one) If life gives you lemons, drink Hefeweizen

12 21

problems with recursive_timed_mutex and scoped lock wont compile in version 1.39
by Clark Sims 07 Sep '09

07 Sep '09

I can compile the following code fine in boost 1.33.1 but it generates compiler errors in version 1.39. I am using visual studio 2005. I will post the code, and then post the compiler errors: #include <iostream> #include <boost/thread/thread.hpp> #include <boost/thread/xtime.hpp> #include <boost/thread/recursive_mutex.hpp> using namespace std; //using namespace boost; using boost::mutex; using boost::thread; using boost::recursive_timed_mutex; using boost::xtime; boost::recursive_timed_mutex hello_mutex; void hello( int thread_id, int iter) { cerr << thread_id << " : " << iter << endl; } void rand_xtime( xtime* xt) { xtime_get( xt, boost::TIME_UTC); //xt.nsec += (rand() % 1000000000); xt->sec += 1 + rand()%5; } void say_hello( int thread_id) { for (int iter=0; iter<5; iter++) { xtime xt; rand_xtime( &xt); thread::sleep(xt); rand_xtime( &xt); { recursive_timed_mutex &refer_hello = hello_mutex; const xtime& refer_xt = xt; recursive_timed_mutex::scoped_timed_lock lock1( refer_hello, refer_xt); if (lock1) { hello( thread_id, iter); } } } } void hello1() { say_hello( 1); } void hello2() { say_hello( 2); } int main() { boost::thread thrd1(hello1); boost::thread thrd2(hello2); thrd1.join(); thrd2.join(); return 0; } Microsoft (R) Program Maintenance Utility Version 8.00.50727.42 Copyright (C) Microsoft Corporation. All rights reserved. Warning: cannot find Makefile.TimedMutex.dep cl.exe /nologo /Ob0 /W3 /EHs /MD /GR /I ".." /D NDEBUG /D WIN32 /D _CONSOLE /FD /c /Fo"Release\TimedMutex\I386\TimedMutex.obj" "TimedMutex.cpp" TimedMutex.cpp c:\boost_1_39\boost\thread\win32\basic_recursive_mutex.hpp(64) : error C2679: binary '+' : no operator found which takes a right-hand operand of type 'const boost::xtime' (or there is no acceptable conversion) c:\boost_1_39\boost/date_time/posix_time/date_duration_operators.hpp(31): could be 'boost::posix_time::ptime boost::posix_time::operator +(const boost::posix_time::ptime &,const boost::gregorian::months &)' [found using argument-dependent lookup] c:\boost_1_39\boost/date_time/date_duration_types.hpp(132): or 'boost::gregorian::date boost::date_time::months_duration<base_config>::operator +(const boost::gregorian::date &,const boost::date_time::months_duration<base_config> &)' [found using argument-dependent lookup] with [ base_config=boost::gregorian::greg_durations_config ] c:\boost_1_39\boost/date_time/posix_time/date_duration_operators.hpp(75): or 'boost::posix_time::ptime boost::posix_time::operator +(const boost::posix_time::ptime &,const boost::gregorian::years &)' [found using argument-dependent lookup] c:\boost_1_39\boost/date_time/date_duration_types.hpp(244): or 'boost::gregorian::date boost::date_time::years_duration<base_config>::operator +(const boost::gregorian::date &,const boost::date_time::years_duration<base_config> &)' [found using argument-dependent lookup] with [ base_config=boost::gregorian::greg_durations_config ] c:\boost_1_39\boost/date_time/time.hpp(139): or 'boost::posix_time::ptime boost::date_time::base_time<T,time_system>::operator +(const boost::gregorian::date_duration &) const' with [ T=boost::posix_time::ptime, time_system=boost::posix_time::posix_time_system ] c:\boost_1_39\boost/date_time/time.hpp(159): or 'boost::posix_time::ptime boost::date_time::base_time<T,time_system>::operator +(const boost::posix_time::time_duration &) const' with [ T=boost::posix_time::ptime, time_system=boost::posix_time::posix_time_system ] while trying to match the argument list '(boost::system_time, const boost::xtime)' c:\boost_1_39\boost/thread/locks.hpp(364) : see reference to function template instantiation 'bool boost::detail::basic_recursive_mutex_impl<underlying_mutex_type>::timed_lock<boost::xtime>(const Duration &)' being compiled with [ underlying_mutex_type=boost::detail::basic_timed_mutex, Duration=boost::xtime ] c:\boost_1_39\boost/thread/locks.hpp(363) : while compiling class template member function 'bool boost::unique_lock<Mutex>::timed_lock(const boost::xtime &)' with [ Mutex=boost::recursive_timed_mutex ] TimedMutex.cpp(36) : see reference to class template instantiation 'boost::unique_lock<Mutex>' being compiled with [ Mutex=boost::recursive_timed_mutex ] NMAKE : fatal error U1077: '"c:\Program Files\Microsoft Visual Studio 8\VC\BIN\cl.exe"' : return code '0x2' Stop.

1 0

Testing down
by K. Noel Belcourt 07 Sep '09

07 Sep '09

Hi, I'm sorry to report that over the weekend the machine and file systems running Boost testing failed. I'm working on resurrecting the testing on another system but it may be tomorrow before testing comes back online. I apologize for the disruption. -- Noel Belcourt

1 0

[Graph] 1.40 Static Link Issue
by Gordon Smith 07 Sep '09

07 Sep '09

There seems to be an unused bool in fruchterman_reingold.hpp: bool vertex_migration = false; Which will cause link errors if included in more than one statically linked library. Gordon.

1 0

[mpi] non-char strings
by Isidor Zeuner 07 Sep '09

07 Sep '09

The last two checkouts I installed both failed passing strings through boost::mpi communication methods when the element type was not char. So maybe someone besides me will have use for the attached patch which makes it work again. I assume this way of passing strings isn't here to stay anyway since boost::serialization also handles strings. Best regards, Isidor

3 5

Release branch test results with MPI dropped on floor
by Steve M. Robbins 06 Sep '09

06 Sep '09

Hi, Now that 1.40 is out, can we get the release branch testing result scripts fixed so that they understand MPI runs? c.f. http://lists.boost.org/Archives/boost/2009/08/155466.php http://lists.boost.org/boost-testing/2009/08/6353.php Thanks, -Steve

4 4

[hs] Quickbook highlighting doesn't work in KDE 4.3
by Andrey Semashev 06 Sep '09

06 Sep '09

I'm not sure it's the right place for this, so sorry if it's off-topic. I'm trying to use Boost.HS* with Kate from KDE 4.3 on Ubuntu 9.04 but it doesn't work. There appears no "boost::hs" group in the Toost->Highlighting menu, neither does it color the quickbook files. Have anyone run into such kind of problems? PS: I successfully used Boost.HS with previous KDE versions (4.1 for sure, not sure about 4.2). This tool really helps to document the library, many thanks to the author. * http://www.drivehq.com/web/matias.capeletto/boost_hs/doc/html/index.html

2 2

Failures for GCC 4.4.1 with gnu++0x
by Beman Dawes 06 Sep '09

06 Sep '09

9 19

[Boost.Function] How about parallel functions?
by Kasra 06 Sep '09

06 Sep '09

Hi, I required to call few functions is separate threads and use the results. However, the code for this looks really ugly, you have to create threads, then join the threads when ever you require the result of the functions. So I have created a boost.parallel_function library that does this seamlessly just like invoking a normal function and it only joins the thread when the value of the function result type is required. Is this library of any interest to any one? Here is the a hello world example: #include <cstdlib> #include <limits> #include <boost/parallel_function.hpp> using namespace boost; int F0() { volatile int x = 0; for(int i=0; i<std::numeric_limits<int>::max()/1024; i++) x ^= std::rand(); return (int)x; } int F2(int y) { volatile int x = 0; for(int i=0; i<std::numeric_limits<int>::max()/512; i++) x ^= std::rand(); return (int)x ^ y; } int main() { typedef boost::parallel_function< void ( ) > f0_type; typedef boost::parallel_function< void (int) > f1_type; f0_type f0( &::F0 ); f1_type f1( &::F1 ); f0_type::result_type r0 = f0(); f1_type::result_type r1 = f1(32); // use r0 and r1 as if they are int r0 += 34; int value = r1 *= r0 + 452; std::cout << "Hello world " << value << std::endl; return 0; } With Best Regards Mr. Kasra Nassiri Department of Mathematics & Computer Science Imperial College London

3 2

Bug in date_time::subsecond_duration
by Jon Spencer 06 Sep '09

06 Sep '09

There is a needless loss of range in the constructor of date_time::subsecond_duration. The argument is multiplied by the resolution of the base_duration, which could potentially overflow, and then divided by frac_of_second. The patch below reduces the amount of overflow and is identical if one resolution is an integer multiple of the other. The same technique is used elsewhere in the file. Also see this posting on the subject (http://lists.boost.org/boost-users/2008/10/41763.php) --- boost/date_time/time_duration.hpp +++ boost/date_time/time_duration.hpp @@ -267,7 +267,7 @@ public: typedef typename base_duration::traits_type traits_type; explicit subsecond_duration(boost::int64_t ss) : - base_duration(0,0,0,ss*traits_type::res_adjust()/frac_of_second) + base_duration(0,0,0,traits_type::res_adjust()<frac_of_second?ss/(frac_of_second/traits_type::res_adjust()):ss*(traits_type::res_adjust()/frac_of_second)) {} };

1 0

Weak pointer to object not managed by a shared_ptr
by Mateusz Loskot 05 Sep '09

05 Sep '09

Hi, One of the smart pointer techniques [1] explains use of weak_ptr pointer to object not managed by a shared_ptr. [1] http://www.boost.org/doc/libs/1_40_0/libs/smart_ptr/sp_techniques.html I'm wondering what would be practical use case of that? Is it a part of any of known idioms or patterns? Also, is it valid to assume that this technique can extend lifetime of X so of the internal integral X::i_ ? Here is a simple test case based on the technique explained in the smartptr docs [1] with my questions marked using XXX tag: /// begin of program /////////////////////////////////////////////// #include <exception> #include <iostream> #include <boost/shared_ptr.hpp> #include <boost/weak_ptr.hpp> using namespace std; using namespace boost; struct null_deleter { void operator()(void const *) const { std::cout << "deleter\n"; } }; class X { public: explicit X(int i): this_(this, null_deleter()), i_(i) {} X(X const & rhs): this_(this, null_deleter()), i_(rhs.i_) {} X & operator=(X const & rhs) { i_ = rhs.i_; return *this; } weak_ptr<X> get_weak_ptr() const { return this_; } int get_i() const { return i_; } private: shared_ptr<X> this_; int i_; }; int main() { try { shared_ptr<X> spx; { X x1(7); // XXX: lifetime is extended here? spx = shared_ptr<X>(x1.get_weak_ptr()); } // XXX: No exception. x1 is still alive, so the pointer valid? cout << spx->get_i() << std::endl; } catch (bad_weak_ptr const& e) { cerr << e.what() << endl; } catch (exception const& e) { cerr << e.what() << endl; } catch (...) { cerr << "unknown error\n"; } return 0; } /// end of program /////////////////////////////////////////////// No exception is thrown and I can It seem that the lifetime of x1, automatic object, has been extended beyond its "natural" scope. Am I correct? However, if I replace retrival of shared_ptr with weak_ptr then of course bad_weak_ptr exception is thrown: shared_ptr<X> spx; weak_ptr<X> wpx; { X x1(7); wpx = x1.get_weak_ptr(); } spx = shared_ptr<X>(wpx); cout << spx->get_i() << std::endl; I'm having problems with understanding of what causes the extention of lifetime of X (so of internal X::i_ object). Is this mechanism similar to binding r-value to "const reference"? I would appreciate if anyone could help me to understand it. References to the C++ standard would be great too. Best regards, -- Mateusz Loskot, http://mateusz.loskot.net Charter Member of OSGeo, http://osgeo.org

7 9

[ptr_container] Questionable strong guarantee of ptr_map::insert()
by Kazutoshi Satoda 05 Sep '09

05 Sep '09

Hi, With current implementation of ptr_map::insert(), if an exception is thrown, the objected pointed by the passed pointer is deleted. Is this really providing strong guarantee as documented? I understand strong guarantee as described here. http://www.boost.org/community/exception_safety.html > The strong guarantee: that the operation has either completed > successfully or thrown an exception, leaving the program state exactly > as it was before the operation started. I think ptr_map::insert() doesn't provide this guarantee because deleting the object is a change of the program state. As more concrete problem, see the attached code. I couldn't find any way to provide strong guarantee for delayed_inserter::insert_ready() using ptr_map. I want ready_value unchanged if an exception is thrown during the insertion. Looking for a solution on a similar situation, I found constructors of shared_ptr. Its documentation clearly says that "If an exception is thrown, delete p is called". And for auto_ptr version, it provides strong guarantee by taking the auto_ptr as non-const reference. I think ptr_map::insert() should follow this manner; document the deletion on exception for raw pointer version, and provide strong guarantee with insert(const key_type& key, std::auto_ptr<U>& x) . The the auto_ptr& version can be a better replacement of the raw pointer version. The required temporary of auto_ptr, instead of key_type, is more expressive (about the purpose of the temporary), and matches the Best Practices shown in the documentation of shared_ptr. http://www.boost.org/libs/smart_ptr/shared_ptr.htm#BestPractices But, introducing the auto_ptr& version seems to cause some change of behavior in client codes using the current pass-by-value version. Is it valid to request (create a ticket) for strong guaranteed (taking auto_ptr&) version while having this compatibility concern? Regards. -- k_satoda #include <memory> #include "boost/ptr_container/ptr_map.hpp" namespace ptr_map_insert_strong_guarantee_demo { class value { public: explicit value(int source); // ... }; class delayed_inserter { public: // ... // This is called from context that knows key and source of value, // but doesn't know the time of insertion. void ready_new(int key, int source) { // OK. // This implementation offers strong guarantee for this call. std::auto_ptr<value> new_value(new value(source)); ready_key = key; ready_value = new_value; } // This is called from context which doesn't know key and value, // but knows the time of insertion. void insert_ready() { if (ready_value.get() != 0) { // I want to offer strong guarantee for this call, // but boost::ptr_map deosn't provide the way to do that; // *** ready_value is deleted when an exception is thrown. *** map.insert(ready_key, ready_value); } } // ... private: int ready_key; std::auto_ptr<value> ready_value; boost::ptr_map<int, value> map; // ... }; }

8 17

[lockfree] how many items are queued?
by Oliver Kowalke 05 Sep '09

05 Sep '09

lockfree.fifo provides the info if the queue is empty or not. is it possible to provide a function std::size_t size() const - returning how many items are queued at a specific timepoint? regards, Oliver -- Jetzt kostenlos herunterladen: Internet Explorer 8 und Mozilla Firefox 3 - sicherer, schneller und einfacher! http://portal.gmx.net/de/go/chbrowser

5 9