- Boost - lists.boost.org

Boost inspection notification (2007-03-04/RC_1_34_0) *X*
by Rene Rivera 04 Mar '07

04 Mar '07

Boost Inspection Report Run Date: 17:03:03 UTC, Sunday 04 March 2007 An inspection program <http://www.boost.org/tools/inspect/index.html> checks each file in the current Boost CVS for various problems, generating this as output. Problems detected include tabs in files, missing copyrights, broken URL's, and similar misdemeanors. Totals: 11447 files scanned 908 directories scanned (including root) 195 problems reported Problem counts: 0 files with invalid line endings 0 bookmarks with invalid characters 3 invalid urls 104 broken links 21 unlinked files 22 file/directory names issues 1 files with tabs 9 violations of the Boost min/max guidelines 35 usages of unnamed namespaces in headers (including .ipp files) Summary: archive (3) bind (1) boost-root (3) build (1) date_time (1) doc (2) filesystem (37) graph (2) iostreams (3) lambda (3) math (8) more (1) mpl (1) multi_array (2) ptr_container (1) python (10) regex (1) regression (32) serialization (1) test (81) type_traits (1) Details: *R* invalid (cr only) line-ending *A* invalid bookmarks, invalid urls, broken links, unlinked files *N* file/directory names issues *T* tabs in file *M* uses of min or max that have not been protected from the min/max macros, or unallowed #undef-s *U* unnamed namespace in header |archive| boost/archive/basic_streambuf_locale_saver.hpp: *N* name exceeds 31 characters boost/archive/impl/xml_wiarchive_impl.ipp: *U* unnamed namespace at line 53 boost/archive/iterators/remove_whitespace.hpp: *U* unnamed namespace at line 57 |bind| boost/bind/placeholders.hpp: *U* unnamed namespace at line 25 |boost-root| index.htm: *A* broken link: doc/hmtl/date_time.html *A* broken link: doc/hmtl/date_time/details.html#changes *A* broken link: more/BoostCon07.html |build| tools/build/v2/test/test_system.html: *A* unlinked file |date_time| libs/date_time/xmldoc/date_time_docs_howto.html: *A* unlinked file |doc| doc/html/boost_math/inverse_complex.html: *A* unlinked file doc/html/jam.html: *A* unlinked file |filesystem| libs/filesystem/doc/do-list.htm: *A* invalid URL (hardwired file): file://?/ *A* invalid URL (hardwired file): file://?/UNC/ libs/filesystem/doc/i18n.html: *A* broken link: convenience.htm#basic_recursive_directory_iterator *A* broken link: exception.htm *A* broken link: operations.htm *A* broken link: operations.htm#Do-the-right-thing *A* broken link: operations.htm#is_directory *A* broken link: operations.htm#is_file *A* broken link: operations.htm#status libs/filesystem/doc/index.htm: *A* broken link: ../build/Jamfile *A* broken link: convenience.htm *A* broken link: fstream.htm *A* broken link: operations.htm#create_directory *A* broken link: operations.htm#create_hard_link *A* broken link: operations.htm#current_path *A* broken link: operations.htm#directory_iterator *A* broken link: operations.htm#equivalent *A* broken link: operations.htm#file_size *A* broken link: operations.htm#initial_path *A* broken link: operations.htm#is_file *A* broken link: operations.htm#is_symlink *A* broken link: operations.htm#status *A* broken link: operations.htm#symlink_status *A* broken link: path.htm#Canonical *A* broken link: path.htm#Grammar *A* broken link: path.htm#Normalized *A* broken link: path.htm#default_name_check *A* broken link: path.htm#name_check_mechanism *A* broken link: path.htm#normalize *A* broken link: path.htm#operator_eq *A* broken link: path.htm#synopsis libs/filesystem/doc/portability_guide.htm: *A* broken link: path.htm#name_check_typedef libs/filesystem/doc/tr2_proposal.html: *A* invalid URL (hardwired file): file:///C|/boost/site/libs/filesystem/doc/operations.htm#complete_note |graph| libs/graph/example/file_dependencies.cpp: *M* violation of Boost min/max guidelines on line 139 libs/graph/test/serialize.cpp: *T* |iostreams| libs/iostreams/doc/acknowledgments.html: *A* unlinked file libs/iostreams/doc/concepts/multi-character.html: *A* unlinked file libs/iostreams/doc/installation.html: *A* broken link: ../../../tools/build/v1/build_system.htm |lambda| boost/lambda/core.hpp: *U* unnamed namespace at line 62 boost/lambda/detail/lambda_functors.hpp: *U* unnamed namespace at line 25 boost/lambda/exceptions.hpp: *U* unnamed namespace at line 24 |math| libs/math/test/common_factor_test.cpp: *M* violation of Boost min/max guidelines on line 146 *M* violation of Boost min/max guidelines on line 147 *M* violation of Boost min/max guidelines on line 193 *M* violation of Boost min/max guidelines on line 194 |more| more/separate_compilation.html: *A* broken link: ../libs/config/test/link/test/Jamfile.v2 |mpl| boost/mpl/alias.hpp: *U* unnamed namespace at line 17 |multi_array| boost/multi_array/base.hpp: *U* unnamed namespace at line 69 libs/multi_array/test/generative_tests.hpp: *U* unnamed namespace at line 57 |ptr_container| libs/ptr_container/doc/tutorial_example.html: *A* unlinked file |python| libs/python/doc/building.html: *A* broken link: ../../../tools/build/v1/build_system.htm *A* broken link: ../../../tools/build/v1/build_system.htm#user_globals *A* broken link: ../../../tools/build/v1/build_system.htm#variants libs/python/doc/tutorial/doc/html/python/hello.html: *A* broken link: ../../../../../example/tutorial/Jamrules libs/python/doc/tutorial/index.html: *A* broken link: ../../../LICENSE_1_0.txt libs/python/doc/v2/May2002.html: *A* broken link: ../../../../tools/build/v1/build_system.htm *A* broken link: ../../../../tools/build/v1/gen_aix_import_file.py libs/python/doc/v2/faq.html: *A* broken link: ../../../../tools/build/v1/build_system.htm |regex| libs/regex/performance/input.html: *A* unlinked file |regression| regression/.htaccess: *N* leading character of ".htaccess" is not alphabetic tools/regression/test/test-cases/incremental/bjam.log.1: *N* name contains more than one dot character ('.') tools/regression/xsl_reports/test/test-components/test_is_test_log_complete/compile-fail.xml: *N* file path will exceed 100 characters in a directory tree with a root of the form boost_X_XX_X/ tools/regression/xsl_reports/test/test-components/test_is_test_log_complete/completed.xml: *N* file path will exceed 100 characters in a directory tree with a root of the form boost_X_XX_X/ tools/regression/xsl_reports/test/test-components/test_is_test_log_complete/expected/compile-fail.xml: *N* file path will exceed 100 characters in a directory tree with a root of the form boost_X_XX_X/ tools/regression/xsl_reports/test/test-components/test_is_test_log_complete/expected/completed.xml: *N* file path will exceed 100 characters in a directory tree with a root of the form boost_X_XX_X/ tools/regression/xsl_reports/test/test-components/test_is_test_log_complete/expected/lib.xml: *N* file path will exceed 100 characters in a directory tree with a root of the form boost_X_XX_X/ tools/regression/xsl_reports/test/test-components/test_is_test_log_complete/expected/misfire.xml: *N* file path will exceed 100 characters in a directory tree with a root of the form boost_X_XX_X/ tools/regression/xsl_reports/test/test-components/test_is_test_log_complete/expected/no-run.xml: *N* file path will exceed 100 characters in a directory tree with a root of the form boost_X_XX_X/ tools/regression/xsl_reports/test/test-components/test_is_test_log_complete/expected/run_pyd.xml: *N* file path will exceed 100 characters in a directory tree with a root of the form boost_X_XX_X/ tools/regression/xsl_reports/test/test-components/test_is_test_log_complete/expected/test-case.xml: *N* file path will exceed 100 characters in a directory tree with a root of the form boost_X_XX_X/ tools/regression/xsl_reports/test/test-components/test_is_test_log_complete/test-case.xml: *N* file path will exceed 100 characters in a directory tree with a root of the form boost_X_XX_X/ tools/regression/xsl_reports/test/test-components/test_is_test_log_complete/test-driver.xsl: *N* file path will exceed 100 characters in a directory tree with a root of the form boost_X_XX_X/ tools/regression/xsl_reports/test/test-components/test_re_match/expected/test_re_match.xml: *N* file path will exceed 100 characters in a directory tree with a root of the form boost_X_XX_X/ tools/regression/xsl_reports/test/test-components/test_test_case_status/explicit-failures-markup.xml.test: *N* file path will exceed 100 characters in a directory tree with a root of the form boost_X_XX_X/ *N* name contains more than one dot character ('.') *N* name exceeds 31 characters tools/regression/xsl_reports/test/test-components/test_test_structure/explicit-failures-markup.xml.test: *N* file path will exceed 100 characters in a directory tree with a root of the form boost_X_XX_X/ *N* name contains more than one dot character ('.') *N* name exceeds 31 characters tools/regression/xsl_reports/xsl/html/issues_legend.html: *A* unlinked file tools/regression/xsl_reports/xsl/html/library_developer_legend.html: *A* unlinked file tools/regression/xsl_reports/xsl/html/library_user_legend.html: *A* unlinked file tools/regression/xsl_reports/xsl/html/make_tinyurl.html: *A* unlinked file tools/regression/xsl_reports/xsl/html/summary_developer_legend.html: *A* unlinked file tools/regression/xsl_reports/xsl/html/summary_user_legend.html: *A* unlinked file tools/regression/xsl_reports/xsl/v2/html/issues_legend.html: *A* unlinked file tools/regression/xsl_reports/xsl/v2/html/library_developer_legend.html: *A* unlinked file tools/regression/xsl_reports/xsl/v2/html/library_user_legend.html: *A* unlinked file tools/regression/xsl_reports/xsl/v2/html/make_tinyurl.html: *A* unlinked file tools/regression/xsl_reports/xsl/v2/html/summary_developer_legend.html: *A* unlinked file tools/regression/xsl_reports/xsl/v2/html/summary_user_legend.html: *A* unlinked file |serialization| libs/serialization/src/basic_xml_grammar.ipp: *U* unnamed namespace at line 43 |test| boost/test/floating_point_comparison.hpp: *U* unnamed namespace at line 206 *U* unnamed namespace at line 228 boost/test/impl/cpp_main.ipp: *U* unnamed namespace at line 42 boost/test/impl/exception_safety.ipp: *U* unnamed namespace at line 400 boost/test/impl/framework.ipp: *U* unnamed namespace at line 199 boost/test/impl/plain_report_formatter.ipp: *U* unnamed namespace at line 45 boost/test/impl/progress_monitor.ipp: *U* unnamed namespace at line 38 boost/test/impl/results_collector.ipp: *U* unnamed namespace at line 106 boost/test/impl/results_reporter.ipp: *U* unnamed namespace at line 48 boost/test/impl/unit_test_log.ipp: *U* unnamed namespace at line 79 boost/test/impl/unit_test_monitor.ipp: *U* unnamed namespace at line 35 boost/test/impl/unit_test_parameters.ipp: *U* unnamed namespace at line 50 boost/test/results_collector.hpp: *U* unnamed namespace at line 40 boost/test/test_tools.hpp: *U* unnamed namespace at line 262 boost/test/utils/iterator/token_iterator.hpp: *U* unnamed namespace at line 166 boost/test/utils/named_params.hpp: *U* unnamed namespace at line 216 boost/test/utils/runtime/cla/dual_name_parameter.ipp: *U* unnamed namespace at line 43 boost/test/utils/runtime/cla/modifier.hpp: *U* unnamed namespace at line 34 boost/test/utils/runtime/env/modifier.hpp: *U* unnamed namespace at line 34 boost/test/utils/runtime/file/config_file.hpp: *U* unnamed namespace at line 169 *U* unnamed namespace at line 64 *U* unnamed namespace at line 74 boost/test/utils/runtime/file/config_file_iterator.hpp: *U* unnamed namespace at line 68 boost/test/utils/trivial_singleton.hpp: *U* unnamed namespace at line 52 *U* unnamed namespace at line 61 libs/test/build/msvc71_proj/config_file_iterator_test.vcproj: *N* name exceeds 31 characters libs/test/doc/components/prg_exec_monitor/compilation.html: *A* broken link: ../../../build/Jamfile libs/test/doc/components/prg_exec_monitor/index.html: *A* broken link: ../../../../../boost/test/cpp_main.hpp libs/test/doc/components/test_tools/index.html: *A* broken link: ../../tests/boost_check_equal_str.html libs/test/doc/components/test_tools/reference/BOOST_CHECK_CLOSE.html: *A* broken link: BOOST_CHECK_CLOSE_FRACTION.html libs/test/doc/components/test_tools/reference/BOOST_CHECK_MESSAGE.html: *A* broken link: BOOST_MESSAGE.html libs/test/doc/components/test_tools/reference/BOOST_CHECK_SMALL.html: *A* broken link: BOOST_CHECK_CLOSE_FRACTION.html libs/test/doc/components/test_tools/reference/tools_list.html: *A* broken link: ../../btl1.gif *A* broken link: BOOST_CHECK_CLOSE_FRACTION.html libs/test/doc/components/utf/compilation.html: *A* broken link: ../../../build/Jamfile libs/test/doc/components/utf/components/index.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/components/test_case/abstract_interface.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_case/auto_register_facility.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_case/boost_function_tc.html: *A* broken link: ../../../../../../../boost/test/unit_test_suite_ex.hpp *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_case/class_tc.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_case/function_tc.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_case/index.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_case/param_boost_function_tc.html: *A* broken link: ../../../../../../../boost/test/unit_test_suite_ex.hpp *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_case/param_class_tc.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_case/param_function_tc.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_case/tc_template.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_log/custom_log_formatter.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_log/index.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_result/index.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_suite/index.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/index.html: *A* broken link: getting_started/index.html libs/test/doc/components/utf/parameters/build_info.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/catch_system_errors.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/detect_memory_leaks.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/index.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/log_format.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/log_level.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/no_result_code.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/output_format.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/random.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/report_format.html: *A* broken link: ../../../../../LICENSE_1_0.txt *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/report_level.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/show_progress.html: *A* broken link: ../../btl1.gif libs/test/doc/examples/unit_test_example1.html: *A* broken link: ../../example/unit_test_example1.cpp libs/test/doc/examples/unit_test_example2.html: *A* broken link: ../../example/unit_test_example2.cpp libs/test/doc/examples/unit_test_example3.html: *A* broken link: ../../example/unit_test_example3.cpp libs/test/doc/examples/unit_test_example4.html: *A* broken link: ../../example/unit_test_example4.cpp libs/test/doc/examples/unit_test_example5.html: *A* broken link: ../../example/unit_test_example5.cpp *A* broken link: ../../example/unit_test_example5.input libs/test/doc/tests/auto_unit_test_test.html: *A* broken link: ../../test/auto_unit_test_test.cpp libs/test/doc/tests/auto_unit_test_test_mult.html: *A* broken link: ../../test/auto_unit_test_test_mult1.cpp *A* broken link: ../../test/auto_unit_test_test_mult2.cpp libs/test/doc/tests/unit_test_suite_ex_test.html: *A* broken link: ../../test/unit_test_suite_ex_test.cpp libs/test/doc/tutorials/hello_the_testing_world.html: *A* broken link: ../../../../../LICENSE_1_0.txt *A* broken link: ../execution_monitor/index.html libs/test/doc/tutorials/new_year_resolution.html: *A* broken link: ../../../../../../LICENSE_1_0.txt |type_traits| libs/type_traits/cxx_type_traits.htm: *A* unlinked file

1 0

[Report] 65 regressions on RC_1_34_0 (2007-03-04)
by Douglas Gregor 04 Mar '07

04 Mar '07

Boost Regression test failures Report time: 2007-03-04T04:43:20Z This report lists all regression test failures on release platforms. Detailed report: http://engineering.meta-comm.com/boost-regression/CVS-RC_1_34_0/developer/i… 65 failures in 9 libraries graph (4) iostreams (10) math (3) numeric/interval (1) optional (12) parameter (1) python (27) regex (4) test (3) |graph| dijkstra_heap_performance: msvc-7.0 graphviz_test: msvc-7.1_stlport4 layout_test: msvc-7.0 relaxed_heap_test: msvc-7.0 |iostreams| bzip2_test: intel-linux-9.0 msvc-7.1 msvc-8.0 file_descriptor_test: gcc-cygwin-3.4.4 gzip_test: intel-linux-9.0 msvc-7.1 msvc-8.0 zlib_test: intel-linux-9.0 msvc-7.1 msvc-8.0 |math| common_factor_test: msvc-6.5 msvc-6.5_stlport4 msvc-7.1_stlport4 |numeric/interval| test_float: msvc-7.1_stlport4 |optional| optional_test: darwin-4.0.1 gcc-3.4.5_linux gcc-3.4.5_linux_x86_64 gcc-4.0.3_linux gcc-4.1.0_linux gcc-4.1.0_linux_x86_64 gcc-4.1.1_sunos_i86pc hp_cxx-71_006_tru64 msvc-6.5 msvc-7.0 optional_test_ref_fail2: msvc-7.1 msvc-8.0 |parameter| python_test: gcc-cygwin-3.4.4 |python| bases: intel-linux-9.0 exec: intel-linux-9.0 import_: cw-9.4 darwin-4.0.1 gcc-3.2.3_linux gcc-3.3.6 gcc-3.3.6_linux gcc-3.4.5_linux gcc-3.4.5_linux_x86_64 gcc-4.0.3_linux gcc-4.1.0_linux gcc-4.1.0_linux_x86_64 gcc-4.1.1_sunos_i86pc hp_cxx-71_006_tru64 intel-linux-9.0 intel-linux-9.0 intel-vc71-win-9.1 msvc-6.5 msvc-7.0 msvc-7.1 msvc-7.1 msvc-8.0 msvc-8.0 msvc-8.0 pointee: intel-linux-9.0 pointer_type_id_test: intel-linux-9.0 upcast: intel-linux-9.0 |regex| regex_regress_threaded: msvc-6.5_stlport4 msvc-7.1_stlport4 msvc-8.0 static_mutex_test: gcc-cygwin-3.4.4 |test| boost_check_equal_str: msvc-6.5 prg_exec_fail3: cw-9.4 test_tools_test: msvc-6.5

1 0

Re: [boost] boost::signal thread safety
by Stjepan Rajko 04 Mar '07

04 Mar '07

> From: Frank Mori Hess <frank.hess(a)nist.gov> > Subject: Re: [boost] boost::signal thread safety > > I'm currently reasonably satisfied with the state of thread_safe_signals. > My plan now is to finish an updated version of the signals documentation > that is sufficient to describe the changes that have been made, and then > put the code and documentation in a tarball so it is easier for people to > try out. Time and experience should clarify any remaining problem areas. > Awesome! I downloaded the library from the sandbox CVS and am looking forward to trying it out. I feel that the "signal flow" mechanism I'm working on makes more sense and has more potential benefits in multi-threaded environments so I'd like to add support for your implementation of signals. Cheers, Stjepan

1 0

Re: [boost] boost::format - incorrect (printf-incompatible) handling of "%u" with characters
by Zack Weinberg 04 Mar '07

04 Mar '07

On 3/4/07, Phil Endecott <phil_ntaqi_endecott(a)chezphil.org> wrote: > > In my opinion this is a bug - both operations should produce "65". > > See my previous report: > > http://thread.gmane.org/gmane.comp.lib.boost.user/23644 > which continues at > http://thread.gmane.org/gmane.comp.lib.boost.user/23664 > > The conclusion at that time was that > - you can just cast to an int if this is what you want. > - you shouldn't be using bytes to store numbers - that's unnecessary > size optimisation. > > I didn't agree with those conclusions, and I'm no longer using boost::format. Yeah, I don't agree with those conclusions either. Not all uses of 8-bit numbers are unnecessary size optimization. Image data, for example, commonly comes as 8 bits per pixel per color, and you may want to print out the numeric values for debugging. Stream ciphers are often defined to produce one byte at a time of keystream. In the case that prompted this bug report, I was using 8-bit numbers as a *time* optimization hint - the compiler needed to know that a narrowing divide was safe. [What did you replace boost::format with?] zw

1 0

Re: [boost] boost::format - incorrect (printf-incompatible) handling of "%u" with characters
by Phil Endecott 04 Mar '07

04 Mar '07

Zack wrote: > Consider the following example program: > > #include <boost/format.hpp> > #include <cstdio> > #include <string> > > int main() > { > unsigned char n = 65; > std::printf("%u\n", n); > std::puts((boost::format("%u") % n).str().c_str()); > } > > $ g++ test.cc > $ ./a.out > 65 > A > > In my opinion this is a bug - both operations should produce "65". See my previous report: http://thread.gmane.org/gmane.comp.lib.boost.user/23644 which continues at http://thread.gmane.org/gmane.comp.lib.boost.user/23664 The conclusion at that time was that - you can just cast to an int if this is what you want. - you shouldn't be using bytes to store numbers - that's unnecessary size optimisation. I didn't agree with those conclusions, and I'm no longer using boost::format. Phil.

1 0

Shared pointers and pointers to members issue (with fix)
by Michael Anderson 04 Mar '07

04 Mar '07

Howdy everyone. I have some code that uses pointers to member variables that I want to switch to using boost::shared_ptrs, some of the code looks like this. class Bar {}; class Foo { public: Bar bar; }; ... Foo * fooptr = new Foo; Bar * barptr = &Foo.bar; ... So to make this work with shared_ptrs I can do this: class Bar {} class Foo { public: Foo() : bar(new Bar) {} shared_ptr<Bar> bar; }; ... shared_ptr<Foo> fooptr(new Foo); shared_ptr<Bar> barptr = fooptr->bar; ... But this means I have to change each of the classes... which is a bit ugly. Also it has unlinked the lifetime of the Bar and Foo objects. So the solution I've come up with means that the Foo object only gets destroyed when both the barptr and the fooptr are destroyed. Unfortunately this requires additions to the shared_ptr class (the patch is below). The changes are _very_ similar to what is used for handling the pointer conversions and casts. Anyway I was wondering whether this is useful to anyone else, and whether there was any pitfalls I might have missed.... Thanks, Mike Anderson Example Usage : #include <iostream> #include "boost/shared_ptr.hpp" class Foo { public: double m; Foo() : m(1.0) { std::cout<<"creating Foo @ "<<this<<std::endl; } ~Foo() { std::cout<<"destroying Foo @ "<<this<<std::endl; } }; int main() { { boost::shared_ptr<Foo> fooptr( new Foo ); { boost::shared_ptr<double> mptr = boost::member_pointer(fooptr, &fooptr->m); } // Foo destroyed here... } { boost::shared_ptr<double> mptr; { boost::shared_ptr<Foo> fooptr( new Foo ); mptr = boost::member_pointer(fooptr, &fooptr->m); } // Foo destroyed here... even though mptr is a pointer to double. } } class Bar {}; class Foo { public: Bar bar; }; shared_ptr<Foo> fooptr(new Foo); shared_ptr<Bar> barptr = boost::member_ptr(fooptr, &fooptr->bar); Patch : (not from the recent trunk of boost....) --- shared_ptr.hpp +++ shared_ptr.hpp @@ -50,6 +50,7 @@ struct const_cast_tag {}; struct dynamic_cast_tag {}; struct polymorphic_cast_tag {}; +struct memberpointer_tag {}; template<class T> struct shared_ptr_traits { @@ -191,6 +192,12 @@ } } + template<class Y, class M> + shared_ptr(shared_ptr<Y> const & r, M* member_ptr, detail::memberpointer_tag) : px( member_ptr ), pn(r.pn) + { + + } + #ifndef BOOST_NO_AUTO_PTR template<class Y> @@ -410,6 +417,11 @@ return shared_static_cast<T>(r); } +template<class T, class M> shared_ptr<M> member_pointer( shared_ptr<T> const & t, M* m) +{ + return shared_ptr<M>(t,m, detail::memberpointer_tag() ); +} + // get_pointer() enables boost::mem_fn to recognize shared_ptr template<class T> inline T * get_pointer(shared_ptr<T> const & p) -- Michael Anderson Chief Technology Officer -- p. +61 8 8400 6496 [Adelaide, Australia] michael.anderson(a)risingsunresearch.com -- Rising Sun Research p. +61 8 8400 6494 - f. +61 8 8400 6401 www.risingsunresearch.com

8 12

Who's using Boost: Google gtags
by Jeff Garland 04 Mar '07

04 Mar '07

Just ran across this today. Uses the Boost.Test http://code.google.com/p/google-gtags/wiki/GTagsInstallation Jeff

2 1

[test][range][BBv2?] issues with sub_range test
by David Abrahams 04 Mar '07

04 Mar '07

I'm seeing the following: 1. The test appears to do invoke undefined behavior, almost knowingly. On line 103, it asks whether a singular range (so named, even) is empty. This range is made up of singular iterators, the comparison of which invokes undefined behavior. In a debug build on VC8 this fires an assertion ("string iterators incompatible"). This problem should be fixed. Every major standard library now has some iterator checking. We should do debug-mode tests of our code with iterator checking on. 2. In VC8 debug builds, the test output is as follows: Running 1 test case... hello worldhello worldhello worldhello worldunknown location(0): fatal error in "check_sub_range": C:\Program Files (x86)\Microsoft Visual Studio 8\VC\INCLUDE\xstring(272) : Assertion failed: string iterators incompatible sub_range.cpp(103): last checkpoint *** 1 failure detected in test suite "Master Test Suite" Here, Boost.Test is doing its job and catching the assertion exception. 3. In VC8 release builds, the test invokes the JIT debugger. As a result, my automated release-mode tests are interfered with. Nothing kills off the resulting JIT dialog, and my repeating test task does not complete, which prevents the next repetition from beginning. I can't understand why that would be the case. Doesn't Boost.Test install an SEH handler? -- Dave Abrahams Boost Consulting www.boost-consulting.com

3 4

[bimap] Late Review
by Giovanni Piero Deretta 04 Mar '07

04 Mar '07

Looks like I didn't make it in time. Ion just announced the result, and I congratulate with Matias for the result of the review. I'll add here my (short) review of the library anyways. First of all, I think that the library should be accepted, but that doesn't matter anyway now :) * What is your evaluation of the design? The design looks sound. Probably the interface is a bit complex for being a simplified wrapper around MI, but on the other hand, Bimap is certainly not a simple wrapper. Still the most common use is bimap<A, B>, and Boost.Bimap makes the simple case simple. I do not buy much the reason for preferring left/right to first/second. At least in an std::pair, their name does not reflect the importance in the sequence (as it might be in an std::map), but just their position in the signature. For the same reason, bmap could use these tags to name the left and right view. The tutorial states: "Be aware that a bidirectional map is only signature-compatible with standard containers. Some functions may give different results, such as in the case of inserting a pair into the left map where the second value conflicts with a stored relation in the container. The functions may be slower in a bimap because of the duplicated constraints. It is strongly recommended that you read The full tutorial if you intend to use a bimap in a serious project." Wouldn't be better to make functions with different behaviour from standard containers *not* signature compatible? I've been bitten at times with function signature compatibility but behaviour incompatibility in standard containers. The lambda support names the placeholder for the left, right, first, second and key with a underscore in the beginning (i.e. "_first"). While I think this is done to mimic the "_1" notation, I think that here the underscore is not really necessary. Probably just "first" would just be better. Also shouldn't support for pair be directly inside boost::lambda? (speaking of it, can we also have built in support for tuples in lambda? Pleeease). * What is your evaluation of the implementation? Didn't study it enough to make a comment. * What is your evaluation of the documentation? Very Good. It is very clean and I like the graphic aspect, while maintaining a Boost look and feel. The pictures used to explain relations help a lot. I also like the color scheme. The index page has a very nice image based menu. While it looks great, it makes it harder to navigate it using the "Find as you type" functionality of Firefox. I use this functionality a lot when navigating documentation. A test based duplicate could be exposed in the page. The one minute tutorial explains very well the the basic bimap<A, B> interface. I've found parts of the extended tutorial a bit non intuitive. In particular the part about "The set of relations type". I had to read it a couple of times, and I do not feel that I still get it completely. But that Is probably just me. The documentation assumes that this is in effect. using namespace bimap; As many have stated before in reviews of other libraries, I think that something like: namespace bm = boost::bimap; would be more appropriate. I think this is not just a matter of style. When reading documentations, I often find myself looking up symbols to see in what namespace are supposed to be (is this symbol from bimap, was it part of another library, is it a local typedef?). Tagging: "member_at::{side}" Here "{side}" is a placeholder for "left/right". But "{" and "}" have meaning in c++, and it took me a while not to parse it as valid code :( . This placeholder syntax is used in other places in the documentation. Probably some other typographic convention should be used. The reference section is impressive, with detailed explanation for every member function. Great job. I liked a lot all the extra sections. The "external dependencies" is welcome. The implementation detail parts provides a very interesting view on some of the rationale for the library. I liked the snippets of conversation with the mentor. * What is your evaluation of the potential usefulness of the library? Extremely useful. While the simple case of two synchronized maps is not hard to do, it is error prone, and often quick ad-hoc implementations do not have the full generality of boost bimap. Going full MultiIndex is an overkill for simple projects (the interface is definitely more complex). The *_of set types add value to the library but probably are going to be less used. * Did you try to use the library? With what compiler? Did you have any problems? No. * How much effort did you put into your evaluation? A glance? A quick reading? In-depth study? I did study the documentation but didn't try the library. * Are you knowledgeable about the problem domain? As many, I had the need to maintain two synchronized std::map to do look up from both sides. I've also used boost.MI. I'm definitely not an expert on MI internals. Ok, that's it. But before finishing, I have thank again Matias for the help in using boost.build and quickboost during the pas SoC. gpd

2 1

[review][bimap] Bimap accepted
by Ion Gaztañaga 04 Mar '07

04 Mar '07

Hi to all, The Bimap library submitted by Matias Capeletto has been accepted into Boost. Thanks to all reviewers and all who contributed to the library in the informal review. Thanks also to Matias for his submission and Joaquin for his mentoring effort on this Google SoC project. We've received 6 reviews (Alisdair, Fernando, Jeff, John, Thorsten and Tony), all of which were positive. If I weren't the review manager, I would also make a positive review of this library, so I'm pretty happy with the results. Now I have a bit of work reviewing all the comments, suggestions and Matias' replies to write an small summary of requested changes and conclusions. The "relation" view, and some basic names ("first"/"second" vs. "left"/"right") were the most active topics. But everyone has considered Bimap useful, well-written, and well documented. I'll post the summary following week. Regards, Ion

2 1