- Boost - lists.boost.org

Boost inspection notification (2006-07-18/RC_1_34_0) *X*
by Rene Rivera 19 Jul '06

19 Jul '06

Boost Inspection Report Run Date: 20:04:59 UTC, Tuesday 18 July 2006 An inspection program <http://www.boost.org/tools/inspect/index.html> checks each file in the current Boost CVS for various problems, generating this as output. Problems detected include tabs in files, missing copyrights, broken URL's, and similar misdemeanors. Totals: 11601 files scanned 900 directories scanned 243 problems reported Problem counts: 0 files with invalid line endings 0 bookmarks with invalid characters 3 invalid urls 146 broken links 28 unlinked files 14 file names too long 38 files with tabs 14 violations of the Boost min/max guidelines Summary: algorithm (1) archive (1) assign (1) boost-root (6) build (12) date_time (1) doc (3) filesystem (37) foreach (1) graph (15) iostreams (2) iterator (8) jam (1) libs (6) math (6) more (32) numeric (4) program_options (1) ptr_container (1) python (5) quickbook (4) range (1) regex (1) regression (13) statechart (2) test (55) tr1 (1) type_traits (1) typeof (16) xpressive (5) Details: *R* invalid (cr only) line-ending *A* invalid bookmarks, invalid urls, broken links, unlinked files *N* file names too long *T* tabs in file *M* uses of min and max that have not been protected from the min/max macros |algorithm| libs/algorithm/string/doc/external_concepts.html: *A* unlinked file |archive| boost/archive/basic_streambuf_locale_saver.hpp: *N* filename > 31 chars |assign| libs/assign/test/ptr_map_inserter.cpp: *T* |boost-root| index.htm: *A* broken link: doc/html/foreach.html *A* broken link: doc/html/typeof.html *A* broken link: doc/html/xpressive.html *A* broken link: libs/filesystem/doc/convenience.htm#basic_recursive_directory_iterator *A* broken link: libs/wave/doc/index.html *A* broken link: sorted_erdos_renyi_generator.html |build| tools/build/v1/build_system.htm: *A* broken link: ../../../doc/html/jam/language.html#jam.language.flow_of_control tools/build/v1/qcc-3.3.1-tools.jam: *N* filename contains more than one dot character ('.') tools/build/v1/qcc-3.3.5-cpp-tools.jam: *N* filename contains more than one dot character ('.') tools/build/v1/qcc-3.3.5-gpp-tools.jam: *N* filename contains more than one dot character ('.') tools/build/v2/example/libraries/util/foo/include/lib1.h: *N* file's directory depth will exceed 8 levels if placed on a CD tools/build/v2/example/make/main.cpp.pro: *N* filename contains more than one dot character ('.') tools/build/v2/index.html: *A* broken link: ../../../doc/html/bbv2.html *A* broken link: ../../../doc/html/bbv2/installation.html tools/build/v2/test/indirect_conditional.py: *T* tools/build/v2/test/project-test3/lib3/Jamfile: *T* tools/build/v2/test/test_system.html: *A* unlinked file |date_time| libs/date_time/xmldoc/date_time_docs_howto.html: *A* unlinked file |doc| doc/html/boost_math/greatest_common_divisor_and_least_common_multiple.html: *N* filename > 31 chars doc/html/boost_math/inverse_complex.html: *A* unlinked file doc/html/boost_tr1.html: *A* broken link: index.html |filesystem| libs/filesystem/doc/do-list.htm: *A* invalid URL (hardwired file): file://?/ *A* invalid URL (hardwired file): file://?/UNC/ libs/filesystem/doc/i18n.html: *A* broken link: convenience.htm#basic_recursive_directory_iterator *A* broken link: exception.htm *A* broken link: operations.htm *A* broken link: operations.htm#Do-the-right-thing *A* broken link: operations.htm#is_directory *A* broken link: operations.htm#is_file *A* broken link: operations.htm#status libs/filesystem/doc/index.htm: *A* broken link: convenience.htm *A* broken link: fstream.htm *A* broken link: operations.htm#create_directory *A* broken link: operations.htm#create_hard_link *A* broken link: operations.htm#current_path *A* broken link: operations.htm#directory_iterator *A* broken link: operations.htm#equivalent *A* broken link: operations.htm#file_size *A* broken link: operations.htm#initial_path *A* broken link: operations.htm#is_file *A* broken link: operations.htm#is_symlink *A* broken link: operations.htm#status *A* broken link: operations.htm#symlink_status *A* broken link: path.htm#Canonical *A* broken link: path.htm#Grammar *A* broken link: path.htm#Normalized *A* broken link: path.htm#default_name_check *A* broken link: path.htm#name_check_mechanism *A* broken link: path.htm#normalize *A* broken link: path.htm#operator_eq *A* broken link: path.htm#synopsis libs/filesystem/doc/portability_guide.htm: *A* broken link: path.htm#name_check_typedef libs/filesystem/doc/tr2_proposal.html: *A* invalid URL (hardwired file): file:///C|/boost/site/libs/filesystem/doc/operations.htm#complete_note libs/filesystem/src/operations.cpp: *T* |foreach| libs/foreach/index.html: *A* broken link: ../../doc/html/foreach.html |graph| boost/graph/adj_list_serialize.hpp: *T* boost/graph/dominator_tree.hpp: *M* violation of Boost min/max guidelines on line 221 *T* boost/graph/erdos_renyi_generator.hpp: *T* boost/graph/maximum_cardinality_matching.hpp: *M* violation of Boost min/max guidelines on line 755 *N* filename > 31 chars *T* boost/graph/plod_generator.hpp: *T* libs/graph/doc/lengauer_tarjan_dominator_tree.htm: *N* filename > 31 chars libs/graph/doc/sorted_erdos_renyi_generator.html: *N* filename > 31 chars libs/graph/example/kevin-bacon2.cpp: *T* libs/graph/test/csr_graph_test.cpp: *T* libs/graph/test/dominator_tree_test.cpp: *T* libs/graph/test/matching_test.cpp: *T* libs/graph/test/random_matching_test.cpp: *T* |iostreams| libs/iostreams/doc/acknowledgments.html: *A* unlinked file libs/iostreams/doc/concepts/multi-character.html: *A* unlinked file |iterator| libs/iterator/doc/filter_iterator_ref.html: *A* unlinked file libs/iterator/doc/indirect_iterator_ref.html: *A* unlinked file libs/iterator/doc/issues.html: *A* unlinked file libs/iterator/doc/iter-issue-list.html: *A* unlinked file libs/iterator/doc/iterator_adaptor_ref.html: *A* unlinked file libs/iterator/doc/iterator_traits.html: *A* broken link: ../../../doc/html/boost_typetraits/category.html#boost_typetraits.transform libs/iterator/doc/make_filter_iterator.html: *A* unlinked file libs/iterator/doc/ref_problem.html: *A* unlinked file |jam| tools/jam/index.html: *A* broken link: ../../doc/html/jam.html |libs| libs/libraries.htm: *A* broken link: math/octonion/index.html *A* broken link: math/quaternion/index.html *A* broken link: math/special_functions/index.html |math| boost/math/complex/acos.hpp: *M* violation of Boost min/max guidelines on line 107 *M* violation of Boost min/max guidelines on line 193 boost/math/complex/asin.hpp: *M* violation of Boost min/max guidelines on line 117 *M* violation of Boost min/max guidelines on line 203 |more| more/getting_started.html: *A* broken link: ../doc/html/jam/building.html more/version_history.html: *A* broken link: ../doc/html/date_time/date_time_io.html *A* broken link: ../doc/html/date_time/details.html#date_time.changes *A* broken link: ../doc/html/date_time/local_time.html *A* broken link: ../libs/math/octonion/index.html *A* broken link: ../libs/math/quaternion/index.html *A* broken link: ../libs/math/special_functions/index.html *A* broken link: doc/html/any.html *A* broken link: libs/bind/bind.html *A* broken link: libs/bind/bind.html#operators *A* broken link: libs/config/index.html *A* broken link: libs/functional/hash/index.html *A* broken link: libs/graph/doc/cuthill_mckee_ordering.html *A* broken link: libs/graph/doc/king_ordering.html *A* broken link: libs/graph/doc/table_of_contents.html *A* broken link: libs/iostreams/doc/index.html *A* broken link: libs/python/doc/index.html *A* broken link: libs/regex/doc/history.html *A* broken link: libs/regex/doc/index.html *A* broken link: libs/signals/doc/index.html *A* broken link: libs/smart_ptr/index.html *A* broken link: libs/thread/doc/index.html *A* broken link: libs/wave/ChangeLog *A* broken link: libs/wave/index.html *A* broken link: more/boost_1_33_0.jpg *A* broken link: people/doug_gregor.html |numeric| boost/numeric/conversion/detail/old_numeric_cast.hpp: *M* violation of Boost min/max guidelines on line 159 *M* violation of Boost min/max guidelines on line 192 libs/numeric/ublas/test/placement_new.cpp: *T* libs/numeric/ublas/test/test11.cpp: *T* |program_options| boost/program_options/positional_options.hpp: *M* violation of Boost min/max guidelines on line 44 |ptr_container| libs/ptr_container/doc/tutorial_example.html: *A* unlinked file |python| boost/python/with_custodian_and_ward.hpp: *M* violation of Boost min/max guidelines on line 93 libs/python/src/converter/type_id.cpp: *T* libs/python/src/exec.cpp: *T* libs/python/test/exec.cpp: *T* libs/python/test/voidptr.cpp: *T* |quickbook| tools/quickbook/doc/html/quickbook/syntax/block.html: *A* broken link: ../../images/caution.png *A* broken link: ../../images/important.png *A* broken link: ../../images/warning.png *A* broken link: ../highlight.html |range| libs/range/test/iterator_range.cpp: *T* |regex| libs/regex/performance/input.html: *A* unlinked file |regression| regression/.htaccess: *N* leading character of one of the path compontents is not alphabetic tools/regression/xsl_reports/xsl/html/issues_legend.html: *A* unlinked file tools/regression/xsl_reports/xsl/html/library_developer_legend.html: *A* unlinked file tools/regression/xsl_reports/xsl/html/library_user_legend.html: *A* unlinked file tools/regression/xsl_reports/xsl/html/make_tinyurl.html: *A* unlinked file tools/regression/xsl_reports/xsl/html/summary_developer_legend.html: *A* unlinked file tools/regression/xsl_reports/xsl/html/summary_user_legend.html: *A* unlinked file tools/regression/xsl_reports/xsl/v2/html/issues_legend.html: *A* unlinked file tools/regression/xsl_reports/xsl/v2/html/library_developer_legend.html: *A* unlinked file tools/regression/xsl_reports/xsl/v2/html/library_user_legend.html: *A* unlinked file tools/regression/xsl_reports/xsl/v2/html/make_tinyurl.html: *A* unlinked file tools/regression/xsl_reports/xsl/v2/html/summary_developer_legend.html: *A* unlinked file tools/regression/xsl_reports/xsl/v2/html/summary_user_legend.html: *A* unlinked file |statechart| libs/statechart/index.html: *A* broken link: ../../../LICENSE_1_0.txt *A* broken link: contact.html |test| boost/test/impl/exception_safety.ipp: *M* violation of Boost min/max guidelines on line 129 libs/test/build/msvc71_proj/config_file_iterator_test.vcproj: *N* filename > 31 chars libs/test/doc/components/prg_exec_monitor/index.html: *A* broken link: ../../../../../boost/test/cpp_main.hpp libs/test/doc/components/test_tools/index.html: *A* broken link: ../../tests/boost_check_equal_str.html libs/test/doc/components/test_tools/reference/BOOST_CHECK_CLOSE.html: *A* broken link: BOOST_CHECK_CLOSE_FRACTION.html libs/test/doc/components/test_tools/reference/BOOST_CHECK_MESSAGE.html: *A* broken link: BOOST_MESSAGE.html libs/test/doc/components/test_tools/reference/BOOST_CHECK_SMALL.html: *A* broken link: BOOST_CHECK_CLOSE_FRACTION.html libs/test/doc/components/test_tools/reference/tools_list.html: *A* broken link: ../../btl1.gif *A* broken link: BOOST_CHECK_CLOSE_FRACTION.html libs/test/doc/components/utf/components/index.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/components/test_case/abstract_interface.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_case/auto_register_facility.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_case/boost_function_tc.html: *A* broken link: ../../../../../../../boost/test/unit_test_suite_ex.hpp *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_case/class_tc.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_case/function_tc.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_case/index.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_case/param_boost_function_tc.html: *A* broken link: ../../../../../../../boost/test/unit_test_suite_ex.hpp *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_case/param_class_tc.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_case/param_function_tc.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_case/tc_template.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_log/custom_log_formatter.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_log/index.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_result/index.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/components/test_suite/index.html: *A* broken link: ../../../btl1.gif libs/test/doc/components/utf/index.html: *A* broken link: getting_started/index.html libs/test/doc/components/utf/parameters/build_info.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/catch_system_errors.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/detect_memory_leaks.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/index.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/log_format.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/log_level.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/no_result_code.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/output_format.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/random.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/report_format.html: *A* broken link: ../../../../../LICENSE_1_0.txt *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/report_level.html: *A* broken link: ../../btl1.gif libs/test/doc/components/utf/parameters/show_progress.html: *A* broken link: ../../btl1.gif libs/test/doc/examples/unit_test_example1.html: *A* broken link: ../../example/unit_test_example1.cpp libs/test/doc/examples/unit_test_example2.html: *A* broken link: ../../example/unit_test_example2.cpp libs/test/doc/examples/unit_test_example3.html: *A* broken link: ../../example/unit_test_example3.cpp libs/test/doc/examples/unit_test_example4.html: *A* broken link: ../../example/unit_test_example4.cpp libs/test/doc/examples/unit_test_example5.html: *A* broken link: ../../example/unit_test_example5.cpp *A* broken link: ../../example/unit_test_example5.input libs/test/doc/tests/auto_unit_test_test.html: *A* broken link: ../../test/auto_unit_test_test.cpp libs/test/doc/tests/auto_unit_test_test_mult.html: *A* broken link: ../../test/auto_unit_test_test_mult1.cpp *A* broken link: ../../test/auto_unit_test_test_mult2.cpp libs/test/doc/tests/unit_test_suite_ex_test.html: *A* broken link: ../../test/unit_test_suite_ex_test.cpp libs/test/doc/tutorials/hello_the_testing_world.html: *A* broken link: ../../../../../LICENSE_1_0.txt *A* broken link: ../execution_monitor/index.html libs/test/doc/tutorials/new_year_resolution.html: *A* broken link: ../../../../../../LICENSE_1_0.txt |tr1| libs/tr1/test/type_traits/tr1_tky_incomplete_type_test.cpp: *N* filename > 31 chars |type_traits| libs/type_traits/cxx_type_traits.htm: *A* unlinked file |typeof| boost/typeof/encode_decode.hpp: *T* boost/typeof/encode_decode_params.hpp: *T* boost/typeof/increment_registration_group.hpp: *N* filename > 31 chars boost/typeof/integral_template_param.hpp: *T* boost/typeof/modifiers.hpp: *T* boost/typeof/register_functions_iterate.hpp: *T* boost/typeof/template_encoding.hpp: *T* boost/typeof/template_template_param.hpp: *T* boost/typeof/type_encoding.hpp: *T* boost/typeof/type_template_param.hpp: *T* boost/typeof/typeof.hpp: *T* boost/typeof/typeof_impl.hpp: *T* libs/typeof/index.html: *A* broken link: ../../doc/html/xpressive.html libs/typeof/test/Jamfile: *T* libs/typeof/test/odr_no_uns1.cpp: *T* libs/typeof/test/odr_no_uns2.cpp: *T* |xpressive| boost/xpressive/detail/static/static.hpp: *T* boost/xpressive/detail/utility/tracking_ptr.hpp: *T* boost/xpressive/traits/detail/c_ctype.hpp: *T* libs/xpressive/index.html: *A* broken link: ../../doc/html/xpressive.html libs/xpressive/perf/regex_comparison.hpp: *M* violation of Boost min/max guidelines on line 64

4 6

Re: [boost] Is there a one-to-one map class in boost?
by Wang Weiwei 19 Jul '06

19 Jul '06

>On 7/17/06, Felipe Magno de Almeida <felipe.m.almeida(a)gmail.com> wrote: >> On 7/17/06, Wang Weiwei <wwwang(a)ccsdl.org> wrote: >> > Hello, >> > >> > Now I'm finding a one-to-one map class, say map1, that support the following syntax: >> > >> > map1 m; >> > >> > m.insert(std::make_pair(k1, v1)); >> > ... >> > key k; >> > value v; >> > >> > v = m[k]; >> > k = m[v]; >> > >> > I know a pair of std::map could provide such functionality. But I think a single obj, if that class >> > exists, would be more elegant. >> > >> > Is there such a class in boost? >> >> Look for multi_index library. There are examples of such usage. > >I am doing a bidirectional map as one of the boost SoC projects (The >class you are looking for is a particular case of it). Basically it is >a stl map like wrapper around Boost.MultiIndex. I will present a first >release to the list as soon as possible. I invite you to participate >in the discussion that will surely follows. >Just give me a few more days :) Another good news! Of course I could struggle to use a pair of class as a temp/ugly solution, and with in mind that a perfert solution is waiting for me. A few days is not a long time. :-) Thanks in advance. > >Best Regards >Matias Capeletto

2 1

[range][string_algo][string_cvt] string concept
by Oleg Abrosimov 19 Jul '06

19 Jul '06

Hello Pavol and Thorsten! In boost 1.33.1 release string_algo was adopted to use boost::range to deal with string abstraction. but in the current release support for null-terminated strings is deprecated and will disappear from range library in the upcoming 1.34.0 release, as stated in current range' documentation. I'm working on string_cvt library for boost, and it has the same need to express a string type or char sequence type in a general way. My question is - what is a planned replacement for boost::range in a relation to null-terminated strings stuff? What you Pavol is planning to do in string_algo to workaround the deprecation mentioned? And maybe what you Thorsten is planning to provide some special range type that can be used to fill this gap? Thanks in advance, Oleg Abrosimov.

2 1

Fw: [BGL] graph coloring
by Wang Weiwei 19 Jul '06

19 Jul '06

>Hello, > >I'm coloring my graph with the following code: > > typedef std::set<std::pair<int, int> > panel_conn_set_t; > panel_conn_set_t panel_conn_set; > > for(...) > { > // get the information of vertices connectivities > // vertices are referred to with int > panel_conn_set.insert(std::make_pair([some int], [some int])); > } > > typedef boost::adjacency_list<boost::vecS, boost::vecS, > boost::undirectedS, > // use the default color map > property<vertex_color_t, default_color_type>, > no_property> graph_t; > typedef property_map<graph_t, vertex_color_t>::type vertex_color_map_t; > typedef boost::graph_traits<graph_t>::vertex_descriptor vertex_descriptor; > typedef boost::graph_traits<graph_t>::edge_descriptor edge_descriptor; > typedef boost::graph_traits<graph_t>::vertex_iterator vertex_iterator; > typedef boost::graph_traits<graph_t>::vertices_size_type vertices_size_type; > > // the only graph object > graph_t g; > > vertex_color_map_t& vertex_color_map = boost::get(vertex_color, g); > > for(panel_conn_set_t::const_iterator it=panel_conn_set.begin(); it!=panel_conn_set.end(); ++it) > { > // using int directly as vecter descriptor > boost::add_edge((*it).first, (*it).second, g); > } > > // ****** method A ****** > vertices_size_type num_colors = boost::sequential_vertex_coloring(g, vertex_color_map); > > // ****** method B ****** > std::vector<vertices_size_type> color_vec(boost::num_vertices(g)); > boost::iterator_property_map<vertices_size_type*, vertex_index_map> > color(&color_vec.front(), get(vertex_index, g)); > vertices_size_type num_colors = boost::sequential_vertex_coloring(g, color); > >The code for 'method A' does not compile, but those for 'method B'(borrowed from the BGL doc, >seems to be an exterior property map implementation) works well. > >Why? Any help will be appreciated. > >Max > Or, the question may be, how to make the method A code work? that means I want to use an internal color property map associated to the graph obj. Another question here is, as was told in the doc, the result from the above code would not necessarily be the optimum/minimum number of colors. And in the 'Graph Coloring ' section of the doc, an ordering implementation, smallest_last_ordering(), is introduced. Unfortunately, I don't know how to make the code to co-operate with above code to get a better result. As information for your reference, one of my graph running in my program has about 28000 vertices, the result I got from the above code, for this example, is that I can color all of the vertices with 9 distinctive colors. Even though it's not optimum, but it's a fairly good result for me. Of course, any better number will be prefered. Thanks for you concern and help. P.S. Probably, I think I've still not clearly understood that how the boot.PropertyMap lib works with BGL, but definitely I will get it. Thanks again. Max

1 0

[system] system_error first draft
by Beman Dawes 19 Jul '06

19 Jul '06

The filesystem proposal accepted by the LWG for TR2 also includes a <system_error> header with a bit of error reporting machinery. In particular, class error_code to encapsulate error codes from the operating system and class system_error to be thrown by exceptions. See http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2006/n1975.html#Diagnost… The plan is to use these classes uniformly in TR2. Presumably we will want Boost implementations, and use them in other Boost libraries besides Boost.Filesystem. Because there are likely to be other small operating system dependent components in the future, I'm suggesting that they go in a separate Boost.System library. I'm about to post a CPU timer component that would also fit nicely into Boost.System IMO. There is an early version of Boost.System stuff in the vault. Go to the System directory at http://boost-consulting.com/vault/ for system-0.1.zip. The preliminary error_code/system_error docs can be viewed online at http://mysite.verizon.net/beman/system_error.html Note some changes from the TR2 version: * Use of the unspecified-bool-type idom to test an error_code object to see if there is a non-zero error code. * Name changes. The problem with naming is that there are functions whose most obvious name is "errno", given the long C, C++, and POSIX tradition. But 17.4.1.2 of the C++ standard specifically says that errno shall be a macro! Boo. Hiss. So that name is out. I'm very curious to hear if people think the newer names are an improvement over the TR2 versions. And any other comments are welcome! --Beman

7 17

Re: [boost] [BGL] graph coloring
by Wang Weiwei 19 Jul '06

19 Jul '06

>> I'm coloring my graph with the following code: >> >> ��vertex_color_map_t& vertex_color_map = boost::get(vertex_color, g); > But this line didn't cause problem. >I wouldn't have expected the above to compile at all; aren't property maps >returned by value? > >D.

1 0

Re: [boost] [BGL] graph coloring
by Wang Weiwei 19 Jul '06

19 Jul '06

>> The code for 'method A' does not compile > >What error message do you get from the compiler ? Thanks, the very first message is: boost_1_33_1\boost\graph\sequential_vertex_coloring.hpp(50) : error C2440: initialization : cannot convert from "int" to "size_type" Max

1 0

Re: [boost] Please don't define a fake "operator <" justfor orderedcontainers
by Martin Bonner 18 Jul '06

18 Jul '06

----Original Message---- From: boost-bounces(a)lists.boost.org [mailto:boost-bounces@lists.boost.org] On Behalf Of Peter Dimov Sent: 11 July 2006 11:18 To: boost(a)lists.boost.org Subject: Re: [boost] Please don't define a fake "operator <" justfor orderedcontainers > Daryle Walker wrote: > >> [1] If you make a fake order for "std::complex<>", would you compare >> real components then imaginary components, or would you use magnitude >> then angle? > > Real, then imaginary. Compare with: Interesting. I would have chosen magnitude and then angle. Why components. > > "If you make a FAKE order for std::string, would you compare left to > right or right to left?" I don't think that is a legitimate comparison. In my world view, strings have a natural order but complex numbers don't. Now admittedly, operator <() for std::string doesn't actually correspond to my natural ordering (Zoë should be less than Zoo, but it isn't), but it is close enough for most purposes and much cheaper than a locale sensitive comparison. -- Martin Bonner Martin.Bonner(a)Pitechnology.com Pi Technology, Milton Hall, Ely Road, Milton, Cambridge, CB4 6WZ, ENGLAND Tel: +44 (0)1223 203894

4 6

Re: [boost] Please don't define a fake "operator <" just forordered containers
by Martin Bonner 18 Jul '06

18 Jul '06

> Daryle Walker wrote: >> ??? Wrote >>> Because operator== has only one purpose in C++: comparison for >>> equality. Operator<, on the other hand, has two common roles. >>> >>> For classes that have natural ordering, it should define this >>> ordering, and then all the other operators (> <= >=) should be >>> defined as well. Classes that doesn't have this natural ordering, >>> often still define operator< just to be able to be used in ordered >>> containers. In such cases, operator< doesn't define a natural >>> ordering because there isn't any. Instead, it just defines an >>> ordering "that works" for ordered containers, nothing more. It >>> doesn't need to compatible with operator== and !=, and defining >>> operators >, <=, >= is misleading and should be avoided. >> >> The later role is invalid. The reason is that the version of STL >> that made it into the Standard specifies an extra parameter for >> ordered containers for a comparison operation. It allows two >> containers of the same element type to use different comparison >> criteria (at compile- and/or run-time). This invalidates the need >> for a fake "operator <" since you can always package the comparison >> routine in an extra parameter. >> Conversely, calling code must not >> hard code use of "operator <" agreed. >> or "std::less<>", disagree >> unless that code >> requires types with a natural ordering. (The standard algorithms >> have variants that either assume "operator <" or take in a >> comparison parameter.) I think specializing std::less<> for types that don't have a natural order is /exactly/ the right way to enable such types to be stored in an associative container. The algorithms are a different case. sort doesn't make sense for a type that doesn't have a natural order, and in that case the user needs to provide an appropriate comparison. >> >> Making a fake "operator <" just for ordered containers invalidates >> the work of those who added comparison parameters in standard >> classes/functions. > > You have a point there, no doubt. On the other hand, Library writers > should supply some kind of functor to be used with their types in > conjunction with ordered containers (when appropriate, and > boost::variant is of course appropriate). How should this functor be > called? You might say there should be some convention, but there isn't > any right now, and some libraries use operator< for this purpose. Is > it > that bad if operator< is the convention? I'm not sure. It's sure is > convenient to use ordered containers like that... And it seems to me > that there is no major drawback to this, because no other order > operator > is provided. But I guess it's highly dependent on taste... > >> The issue is different for the "==" and "!=" operators because two >> objects can have their state checked for equivalence without having >> a standardized order. The "std::complex<>" template classes are an >> example. > > std::complex doesn't have operator<. std::tr1::shared_ptr does. So it > seems the standard isn't very helpfully consistent here... > >>> boost::shared_ptr is a good example of such a class with no natural >>> ordering, with operator== and !=, with operator<, but without the >>> other operators. And shared_ptr is of TR1 strength... >> >> Ordering for pointers is generally defined if both pointers are part >> of the same array segment. (Either one or both of the pointers can >> be at the "one-past-the-end" point of said segment.) If two >> "shared_ptr" objects can be used for points in an array segment[1], >> then comparison can be allowed with ALL four operators ("<", ">", >> "<=", and ">="). Otherwise, none of those operators should be >> defined and any current existence of such operators should be >> considered a bug. > > I didn't quite understand that last paragraph. shared_ptrs doesn't > have > to point to objects in array (actually, they better not), but there > can > be arrays of shared_ptrs. So should the shared_ptr class provide order > operators or shouldn't it? Anyway, the committee already made up it > mind > about the answer to this question... > > _______________________________________________ > Unsubscribe & other changes: > http://lists.boost.org/mailman/listinfo.cgi/boost -- Martin Bonner Martin.Bonner(a)Pitechnology.com Pi Technology, Milton Hall, Ely Road, Milton, Cambridge, CB4 6WZ, ENGLAND Tel: +44 (0)1223 203894

5 7

Re: [boost] Please don't define a fake "operator <" justfororderedcontainers
by Sohail Somani 18 Jul '06

18 Jul '06

> -----Original Message----- > From: boost-bounces(a)lists.boost.org > [mailto:boost-bounces@lists.boost.org] On Behalf Of me22 > Sent: Monday, July 10, 2006 5:07 PM > To: boost(a)lists.boost.org > Subject: Re: [boost] Please don't define a fake "operator <" > justfororderedcontainers > > On 7/10/06, Sohail Somani <s.somani(a)fincad.com> wrote: > > Isn't shared_ptr<T> is supposed to be like T* which has ordering? In > > this case, it's a non-issue no? > > > My understanding is that < is only well-defined for pointers into the > same array and that < between to arbitrary pointers is otherwise some > sort of UB. > > It's less<T*> that provides a full ordering for arbitrary T*s. (By > specialising std::less.) Sorry for the double email, but I guess with this information atleast we can verify that operator < is using less?

2 1