- Boost - lists.boost.org

Re: Formal Review: Indexed Set
by Arkadiy Vertleyb 28 Mar '04

28 Mar '04

Hi Joaquin, Sorry for joining this discussion so late, but here are my comments: - What is your evaluation of the design? - What is your evaluation of the implementation? The code looks clean. One minor question: the index class template's equal_range method forwards to lower/upper_bound. Is it really the best you can achieve here or is it just a temporary shortcut? - What is your evaluation of the documentation? I read the "tutorial" part. I believe the documentation is excelent -- does a great job of explaining things, and provides excelent examples to just be copy-pasted into the code for one to get started. - What is your evaluation of the potential usefulness of the library? At least once in my previous experience I had to maintain multiple synchronized collections. This project would have greatly benefitted from a library like the indexed set. I also think that the "compatible predicate" feature, so unfortunately missing from the std::set, is very useful. We are currently using the library to provide a set-based implementation for our RTL tables. This is not posted yet, but we hope to post it soon. We plan to eventially make the Indexed set-based table implementation default for our tables. - Did you try to use the library? With what compiler? Did you have any problems? Yes, with VC7.1. I did not have any problems related to the Indexed set. - How much effort did you put into your evaluation? A glance? A quick reading? In-depth study? I read the "tutorial" part of the documentation. Then I wrote Indexed set-based RTL table implementation, and made it default for RTL tables. After this I (eventially) successfully compiled and ran RTL tests, which, by that time all internally utilized the indexed set. I had to solve a few issues that showed up, but turned out to be our own issues (thanks for helping us to discover them). - Are you knowledgeable about the problem domain? I use STL collections a lot but never attempted to implement any non-trivial collection (I don't know if this is qualifies as domain knowledge). - Do you think the library should be accepted as a Boost library? Yes, definitely. Arkadiy

1 0

What should be called? [was: BOOST_CHECK_EQUAL fails...]
by Stefan Slapeta 28 Mar '04

28 Mar '04

Sorry for the repost, but there was no answer to this (http://tinyurl.com/3yba8) and I'm still not sure if it is a compiler or a boost defect. Which f should be called here? void f(const char*) { std::cout << "function called!" << std::endl; } template <typename T> void f(const T&) { std::cout << "function template called!" << std::endl; } int main() { char buf[10] = { 0 }; f(buf); } In my opinion, it should be the function template (which whould also mean that EDG works correctly and VC 7.1 not) as "f(char[10])" is no exact match for the function. However, this would also mean that there is a defect in boost.test (see link above). br, Stefan *********************************** Stefan Slapeta Wien/Vienna, Austria http://www.slapeta.com

2 2

Re: [boost] Formal Review: Indexed Set
by JOAQUIN LOPEZ MU?Z 28 Mar '04

28 Mar '04

Hi Tom, thank you for taking the effort to review indexed_set. ----- Mensaje original ----- De: Tom Brinkman <reportbase(a)yahoo.com> Fecha: Domingo, Marzo 28, 2004 7:46 am Asunto: [boost] Formal Review: Indexed Set > * What is your evaluation of the design? > * What is your evaluation of the implementation? > > This is a very creative and impressive library. It > might become as useful > as the boost::lambda, boost::spirit and > boost::function libraries are for me. > > This library has many features that would be useful > generally to many enterprise > applications. > > * What is your evaluation of the documentation? > > Again, excellant. Great work. > > * What is your evaluation of the potential usefulness > of the library? > > Being able to sort sequences of elements by more than > one sorting criteria is useful > to me. I also am intrigued by the lookup operations > and updating functionality, > mentioned in the help file, although I did not test > these. > > * Did you try to use the library? > > I compiled the samples successfully with gcc. I > re-worked the basic sample to get > a feel for some of the functionality. > > * How much effort did you put into your evaluation? > > Compiled samples and read help files. I created a > small test application. > > * Are you knowledgeable about the problem domain? > > Yes. > > * Do you think the library should be accepted as a > Boost library? > > Yes. > Thank you! If you feel in the mood, you might want to contribute your opinions about naming issues (I'll try to compose a unified naming scheme pleasing as many people as possible) The points under discussion are listed at http://groups.yahoo.com/group/boost/files/indexed_set_review_notes.html Regards, Joaquín M López Muñoz Telefónica, Investigación y Desarrollo

1 0

Formal Review: Indexed Set
by Tom Brinkman 28 Mar '04

28 Mar '04

* What is your evaluation of the design? * What is your evaluation of the implementation? This is a very creative and impressive library. It might become as useful as the boost::lambda, boost::spirit and boost::function libraries are for me. This library has many features that would be useful generally to many enterprise applications. * What is your evaluation of the documentation? Again, excellant. Great work. * What is your evaluation of the potential usefulness of the library? Being able to sort sequences of elements by more than one sorting criteria is useful to me. I also am intrigued by the lookup operations and updating functionality, mentioned in the help file, although I did not test these. * Did you try to use the library? I compiled the samples successfully with gcc. I re-worked the basic sample to get a feel for some of the functionality. * How much effort did you put into your evaluation? Compiled samples and read help files. I created a small test application. * Are you knowledgeable about the problem domain? Yes. * Do you think the library should be accepted as a Boost library? Yes. Tom Brinkman __________________________________ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html

1 0

Re: [boost] Formal Review: Indexed Set
by JOAQUIN LOPEZ MU?Z 28 Mar '04

28 Mar '04

Hi Jeff ----- Mensaje original ----- De: Jeff Garland <jeff(a)crystalclearsoftware.com> Fecha: Sábado, Marzo 27, 2004 4:55 pm Asunto: Re: [boost] Formal Review: Indexed Set > // why doesn't this work? > //typedef nth_iterator_type<date_to_string_bimap,2>::type to_map_itr; It is typedef nth_iterator_type<date_to_string_bimap,1>::type to_map_itr; Index numbering is 0-based. I think this is the only problem in the program. If you have further problems please tell me so. Joaquín M López Muñoz Telefónica, Investigación y Desarrollo

3 2

RE: [boost] Re: Boost.Thread and BoostBook
by Reece Dunn 28 Mar '04

28 Mar '04

Michael Glassford wrote: >Douglas Gregor wrote: >Well, that gets me a little farther, but now xsltproc.exe crashes. The >output is attached to the end of the message. >I noticed it was defaulting to gcc, which I don't have installed, so I also >added "using msvc ;" to user-config.jam. It warns me that it found two >versions, 6 and 7.1, and that it will use 7.1, but still crashes. If I >instead add "using msvc : : c:/msvs6/vc98/bin ;" to force it to use MSVC6 >(because version 7.1 unfortunately isn't my main compiler, though we're >thankfully finally moving that way), I get the same result. I think it uses the gcc toolset regardless as a target to put the XIncluded document file in so it will work within bjam/BBv2 (I could have this wrong, as I am not a Boost.Build expert). >Any ideas about this, now? Have you checked the catalog.xml file to see if the namespace aliases are pointing to the correct locations? Does it work when you don't set the XSL/DTD environment variables, but download from the internet? (This will be slow, but it may show if the error is with the program settings or the XSL/DTD settings). Are you building from the Windows or cygwin/Linux shell? If you are using cygwin/Linux, you could try something like: using boostbook : /cygdrive/d/devel/libraries/docbook/xsl/ : /cygdrive/d/devel/libraries/docbook/dtd/ ; Regards, Reece _________________________________________________________________ Express yourself with cool new emoticons http://www.msn.co.uk/specials/myemo

2 1

Formal Review: Indexed Set
by Jeff Garland 28 Mar '04

28 Mar '04

Let me start by saying thanks to Joaquín for the contribution of this library. The amount of effort here is staggering. I believe this will be a very handy addition to boost. * What is your evaluation of the potential usefulness of the library? Quite useful -- library provides solution to frequently requiring design problem with stl collections. It will effectively replace lots of poorer hand-coded solutions. * What is your evaluation of the documentation? Good. Quite extensive. I didn't have time to read it all. I also ran checklink on docs -- no broken links. * Did you try to use the library? With what compiler? Did you have any problems? Yes. Compiled examples and test with gcc 3.3.1 on Mandrake 9.2 against Boost 1.31. All tests passed. I also successfully wrote some code that uses library. Only problem was mine. I was having a 'Pascal' moment -- starting my index at 1 instead of zero ;-) * How much effort did you put into your evaluation? ~5 hours spent. Read docs, compiled examples, wrote programs. * Are you knowledgeable about the problem domain? Sure, if using standard collections counts ;-) * What is your evaluation of the design? Overall the design appears to be quite solid and complete. * What is your evaluation of the implementation? Cursory glance thru implementation. Overall the source seems well organized and conforms with boost standards. Of course, like many boost libraries reading the code in this library is a challenge, even though it is well written. * Do you think the library should be accepted as a Boost library? Yes. ********* Now for some questions / comments: 1) Dead code in index_node.hpp? I don't think the ':' is legal below -- I assume this is dead code? template<typename Super> struct index_node_trampoline:index_node_impl{}; template<typename Super> struct index_node:Super,index_node_trampoline<Super> ... 2) bidirectional_map My first interest in this library started when it was just a bi-directional map. Now it has become something much broader and more powerful. Curiously, the bi-directional map part seems to have taken a back seat -- being pushed into the examples as an 'exercise for the reader'. I think that this is unfortunate. I like to see bidirectional_map as an official part of the library. A few reasons for this: a) bidirectional_map will be documented up front as a part of the library. b) For me it is my current primary use of this library -- even though it is now so flexible I'll have to rethink how I use containers in designs. c) Complex code is pushed on the user. For example, the code below is from examples/bimap.cpp template<typename FromType,typename ToType> struct bidirectional_map { typedef std::pair<FromType,ToType> value_type; #if defined(BOOST_NO_POINTER_TO_MEMBER_TEMPLATE_PARAMETERS) ||\ defined(BOOST_MSVC)&&(BOOST_MSVC<1300) ||\ defined(BOOST_INTEL_CXX_VERSION)&&defined(_MSC_VER)&&(BOOST_INTEL_CXX_VERSION<=700) .... It is obvious from this that there are some portability issues. Putting this sort of detail on library users is too mcch to expect from users in my opinion. But it is only a suggestion since it took me all of 5 minutes to pull out the core of the example to a header file. 3) Serialization support In future directions you say "Once Robert Ramey's serialization library gets accepted into Boost..." I'd love to see Joaquín at least attempt this soon -- it would serve as an excellent review of serialization which is upcoming shortly :-) 4) Should the SGI/HP copyrights be included in the source files which are based off the stl_tree.h implementation? 5) Naming For the namespace/library name I suggest boost::multiindex_containers. Rationale: -- The library provides several stl-like container types (set, list, map) -- hence the plural 'containers'. -- The containers all have multiple indexes -- hence multiindex. I don't have an opinion on the other naming issues. Jeff

1 0

RE: [boost] Standard C Library and C++ / BOOST
by Reece Dunn 28 Mar '04

28 Mar '04

Klaus Nowikow wrote: >Reece Dunn wrote: >[snip] > > A trick I use when handling HRESULT error codes is to have a > > class like this > > (adapted for int error type): > > > > class errorcheck > > { >[snip] > > public: > > inline errorcheck( int ec ): error( ec ) > > { > > if( ec < 0 ) throw( *this ); > > } > >Careful. Throwing an exception from a constructor >means that the object won't be constructed (i. e., does not exist). >So you are throwing a non-existing object here. > >Or am I wrong? If I've got the standard correct, the object will be partially constructed up to the point where the exception is thrown. Thus, if this throws an exception, the error member will be set. If you had: struct test { errorcheck ec; std::string msg; test(): ec( -1 ), msg( "hello" ) { } }; an exception will be generated before the msg string is set and thus test would be invalid. However, I use it like: class myfile { ... myfile( const char * fn ) { errorcheck ec = open( fn, ... ); } ~myfile() { close( ... ); } }; where because the file is not opened if an exception is thrown above, it will not call the destructor to close a non-opened file. Regards, Reece _________________________________________________________________ Express yourself with cool new emoticons http://www.msn.co.uk/specials/myemo

3 2

Is there any mirrors of boost?
by 胡香冬 28 Mar '04

28 Mar '04

I cannot access www.boost.org, :(

2 1

Re: [boost] Re: Formal Review: Indexed Set
by JOAQUIN LOPEZ MU?Z 27 Mar '04

27 Mar '04

Hi Joerg ----- Mensaje original ----- De: jhr.walter(a)t-online.de (Joerg Walter) Fecha: Sábado, Marzo 27, 2004 6:44 pm Asunto: Re: [boost] Re: Formal Review: Indexed Set > > OTOH it might be surprising to search for the components of one > library in > different namespaces. Yes, probably indexed_set should live in boost::container::whatever with the rest of associated components, and additionally, be lifted to boost or boost::container. > > Two more remarks: > > 1. Documentation > > My linux browser (konqueror) has difficulties to correctly display the > indexed_set documentation. HTML tidy shows a couple of problems. Please send them to me privately and I'll try to fix them. > > 2. Performance test > > Compiling the performance tests with ICC 8.0 uncovered a problem in > indexed_set.hpp: > > 67,69c67,69 > < template <typename,typename,typename,typename> friend class > detail::index_base; > < template <typename,typename> friend class > detail::header_holder; > < template <typename,typename> friend class > detail::converter; > --- > > template <typename,typename,typename> friend class > detail::index_base;> template <typename,typename> > friend class > detail::header_holder; > > template <typename,typename> friend class > detail::converter; There's an extra typename in the friend declaration for index_base, right? I wonder how this splipped through unnoticed for so long. I'll fix it, thanx for the tip. > Test results for GCC 3.3.2 > > 1 regular index > 10^3 elmts: 141.24% > 10^4 elmts: 147.67% > 10^5 elmts: 152.57% > space gain: 100.00% > 1 sequenced index > 10^3 elmts: 154.99% > 10^4 elmts: 157.43% > 10^5 elmts: 153.71% > space gain: 100.00% > 2 regular indices > 10^3 elmts: 108.23% > 10^4 elmts: 124.78% > 10^5 elmts: 121.79% > space gain: 90.00% > 1 regular index + 1 sequenced index > 10^3 elmts: 123.96% > 10^4 elmts: 137.12% > 10^5 elmts: 145.98% > space gain: 87.50% > 3 regular indices > 10^3 elmts: 100.11% > 10^4 elmts: 119.70% > 10^5 elmts: 129.12% > space gain: 86.67% > 2 regular indices + 1 sequenced index > 10^3 elmts: 99.25% > 10^4 elmts: 113.62% > 10^5 elmts: 116.37% > space gain: 84.62% > > Test results for ICC 8.0 > > 1 regular index > 10^3 elmts: 105.45% > 10^4 elmts: 106.74% > 10^5 elmts: 105.98% > space gain: 100.00% > 1 sequenced index > 10^3 elmts: 112.29% > 10^4 elmts: 112.20% > 10^5 elmts: 111.43% > space gain: 100.00% > 2 regular indices > 10^3 elmts: 63.17% > 10^4 elmts: 67.35% > 10^5 elmts: 71.65% > space gain: 90.00% > 1 regular index + 1 sequenced index > 10^3 elmts: 65.19% > 10^4 elmts: 69.00% > 10^5 elmts: 72.62% > space gain: 87.50% > 3 regular indices > 10^3 elmts: 49.76% > 10^4 elmts: 57.97% > 10^5 elmts: 60.94% > space gain: 86.67% > 2 regular indices + 1 sequenced index > 10^3 elmts: 49.07% > 10^4 elmts: 52.71% > 10^5 elmts: 51.55% > space gain: 84.62% > > I don't have an explanation for the difference. > How have you compiled the performance test in GCC? Maybe you forgot to turn on optimization flag -O3. The library has a jamfile that builds all the test, examples and the eprformance test, if you use this the performance program should compile in release mode. I except performance results to be roughly the same as with GCC 3.3.1, which I measured in my performance section. Joaquín M López Muñoz Telefónica, Investigación y Desarrollo

1 0