- Boost - lists.boost.org

Please create a category for atomic, context, and lockfree in trac
by Hartmut Kaiser 02 Sep '12

02 Sep '12

Please create a category for atomic, context, and lockfree in trac. Thanks! Regards Hartmut --------------- http://boost-spirit.com http://stellar.cct.lsu.edu

3 4

[Review:Contract] Some questions
by Vicente J. Botet Escriba 02 Sep '12

02 Sep '12

Hi, First of all, thanks Lorenzo for your work on pre-processor programming. With this library, you have showed to me how far the pre-processing can go in terms of expressiveness. I have some questions before doing a complete the review: = C++11 compatibility = * Does the library use c++11 features when available? I was thinking e.g. on the emulated virtual specifiers. BTW, I think the "new" virtual specifier was removed from the standard, but maybe I'm wrong. * I think the library don't allow to declare C++11 specific classes/function. E.g * variadic templates * noexcept functions * constexpr functions * class/function attributes BTW, I have not see any example using exception specifications using 'throws'. Does the library support them? Could you confirm? and if not, could you tell us if you have a plan to support them? = Postconditions result = "Postconditions can access the function return value by declaring a variable of type |auto| and assigning it to the |return| keyword (the variable name is arbitrary but |result| is often used)." What prevent the library to the use of return instead of an auto variable postcondition( // Postconditions. auto old_value = CONTRACT_OLDOF value, // Old value(s). value == old_value + 1, // Assertion(s)... return == old_value ) instead of postcondition( // Postconditions. auto result = return, // Result value. auto old_value = CONTRACT_OLDOF value, // Old value(s). value == old_value + 1, // Assertion(s)... result == old_value ) =Constant assertions = I would expect that the old are always const so the following postcondition( auto old_even = CONTRACT_OLDOF even, auto old_odd = CONTRACT_OLDOF odd, // `[old_]even` and `[old_]odd` all `const&` within assertions. const( even, old_even ) even == old_even + 2, const( odd, old_odd ) odd == old_odd + 2 ) should be rewritten without loss of semantics as postcondition( auto old_even = CONTRACT_OLDOF even, auto old_odd = CONTRACT_OLDOF odd, // `[old_]even` and `[old_]odd` all `const&` within assertions. const( even ) even == old_even + 2, const( odd ) odd == old_odd + 2 ) = Oldof = As the old of value must be declared using a variable, using a specif oldof keyword that will replace auto old_size = CONTRACT_OLDOF size(), by oldofold_size = size(), could simplify the syntax. What do you think? Some minor points: * Why do you use( void ) instead of () in the functions without parameters? e.g. public: bool empty ( void ) const { return vector_.empty(); } Some suggestions: * Use 2 spaces indentation instead of 4 could reduce the width of the page, in particular when you use several columns. * The use of'int const' as return type is verbose and could be replaced by just int. Best, Vicente

2 21

[context] Recent changes (rev. 80363) break compilation
by Hartmut Kaiser 02 Sep '12

02 Sep '12

Hey all, The latest commit to trunk (rev. 80363) breaks compilation of Boost.Context on Windows. I'm attaching a patch fixing the issue. Ok to commit? Regards Hartmut --------------- http://boost-spirit.com http://stellar.cct.lsu.edu

2 2

[Review:Contract] Base class preconditions not checked
by Steven Watanabe 02 Sep '12

02 Sep '12

AMDG Test case attached. The problem is that the precondition test is executed when initializing a virtual base. Virtual bases are always initialized by the most derived class, so the preconditions of base class constructors are never checked. In Christ, Steven Watanabe

2 1

[lockfree] Inconsistent typedef tag_t in tagged_ptr
by Hartmut Kaiser 02 Sep '12

02 Sep '12

Hey all, The embedded typedef <...> tag_t has inconsistent visibility in the two implementations of tagged_ptr. In tagged_ptr.hpp this typedef is 'public', while in the file tagged_ptr_ptrcompression.hpp this typedef is 'private'. Would it be possible to make it public in both cases (patch attached)? Regards Hartmut --------------- http://boost-spirit.com http://stellar.cct.lsu.edu

2 2

[context] Windows ctx::maximum_stacksize() runtime asserts
by Hartmut Kaiser 02 Sep '12

02 Sep '12

Hey all, The Windows implementation of boost::ctx::maximum_stacksize() does always assert: std::size_t maximum_stacksize() { BOOST_ASSERT( ! is_stack_unbound() ); static std::size_t stacksize = 8 * 1024 * 1024; return stacksize; } That is because is_stack_unbound() will unconditionally return true. Patch is attached - ok to commit? Regards Hartmut --------------- http://boost-spirit.com http://stellar.cct.lsu.edu

2 2

MPI maintainer?
by Ralf Grosse-Kunstleve 02 Sep '12

02 Sep '12

Who is currently maintaining Boost MPI? We have two trac items I'd like to assign to the MPI maintainer. The first one has been sitting there for a long time already. https://svn.boost.org/trac/boost/ticket/6123 https://svn.boost.org/trac/boost/ticket/7316 Ralf

1 0

[test] Boost.Test unreleased since November 2009 ?
by Mathieu Champlon 02 Sep '12

02 Sep '12

Hi, I've noticed that no merge has been made from trunk to the release branch for Boost.Test since November 2009, meaning that a lot of bug fixes and features have remained unreleased. Is it on purpose ? Thanks, MAT.

2 1

[test] Where should I put replacement functions for WinCE?
by Jan Hudec 02 Sep '12

02 Sep '12

Hello Folks, Windows CE don't have time and clock functions, getenv function and errno.h (though they seem to have _errno function). I needed to define these things to get Boost.Test to build for WinCE. Now it would be nice to have this work by default. I can provide the definitions (they are quite simple), but I am not sure where would be correct place for them. Should I add them to config/platform/win32.hpp, create config/platform/wince.hpp or put them just in test? Thanks, Jan -- Jan 'Bulb' Hudec <bulb(a)ucw.cz>

2 1

[test] sigaltstack does not work on older Android
by Jan Hudec 02 Sep '12

02 Sep '12

Hello Folks, Android NDK contains several "platforms", depending on which release one desires to be compatible with. Boost test compiles fine with android-8 and newer, but the older versions have incomplete definition of sigaltstack (they define the structure, but not the function), causing compilation error in boost/test/detail/impl/execution_monitor.ipp. I have fixed it locally by adjusting the condition for defining BOOST_TEST_USE_ALT_STACK, but I am not sure which level of fix would be best suited for integrating in boost. I see 3 options: 1. Leaving it as is and simply saying android is only supported from API level 8 (that's 2.2; we are still compiling for 2.1 (which has no changes in native since 2.0)) 2. Simply disabling BOOST_TEST_USE_ALT_STACK in Android; it's not necessary after all. 3. Being really precise and reading the API version, but that requires including extra header. It would be nice, but I am not sure what is the correct place to include it. Here is a simple patch that just disables sigaltstack for Android: --- a/boost/test/impl/execution_monitor.ipp +++ b/boost/test/impl/execution_monitor.ipp @@ -173,7 +173,7 @@ namespace { void _set_se_translator( void* ) {} } # endif # endif -# if !defined(__CYGWIN__) && !defined(__QNXNTO__) +# if !defined(__CYGWIN__) && !defined(__QNXNTO__) && !defined(__ANDROID__) # define BOOST_TEST_USE_ALT_STACK # endif And here is a more complex patch that on android (the __ANDROID__ macro is predefined by the compiler in Android NDK) reads the api-level and uses it to decide: --- a/boost/test/impl/execution_monitor.ipp +++ b/boost/test/impl/execution_monitor.ipp @@ -173,7 +173,11 @@ namespace { void _set_se_translator( void* ) {} } # endif # endif -# if !defined(__CYGWIN__) && !defined(__QNXNTO__) +# if defined(__ANDROID__) +# include <android/api-level.h> +# endif + +# if !defined(__CYGWIN__) && !defined(__QNXNTO__) && (!defined(__ANDROID__) || __ANDROID_API__ >= 8) # define BOOST_TEST_USE_ALT_STACK # endif -- Jan 'Bulb' Hudec <bulb(a)ucw.cz>

2 1