One thing I forgot to mention: when building with cmake, targets should also be generated for the example executables (either by default or by setting an appropriate option). This will make it easier for users to step through them in the debugger to learn how the library works. From: Matt Borland via Boost <boost@lists.boost.org> Date: Monday, 13 October 2025 at 13:20 To: mungo.gill@me.com <mungo.gill@me.com> Cc: Boost developers' mailing list <boost@lists.boost.org>, John Maddock <jz.maddock@googlemail.com>, Matt Borland <matt@mattborland.com> Subject: [boost] Re: [boost][decimal] Mungo's review
- - Compilation failures on Windows ARM
I thought I had already added win-arm runners to GHA, but apparently not.
- - fmtlib library support
The removal of {fmt} from automatic inclusion is cycling in a PR now since Reuben brought this up as well in his review.
It is slightly confusing having implicit integer construction, but explicit floating point construction. Consider making all construction explicit.
Yes, I think that's been the majority opinion so far.
- - locale support
Will fix.
My view would be that we should accept this library.
Overall the documentation could be improved, and some useful features are missing, but in its current form (assuming the bugs and build issues mentioned above and in the mailing list are addressed) it is in a usable state and would be a useful addition to Boost.
Thank you for your detailed review and comments. Matt