On Wed, Aug 20, 2025 at 2:20 PM Seth via Boost <boost@lists.boost.org> wrote:
E.g. in the case of that any_completion_handler PR I think it got paired up with a considerable revamp of the associator traits (although I might suffer from hazy memory and merely remember these changes occurring around the same release). A lot of the time Chris sees a change request as a reason to improve implementation details, often with large impact outside the feature at hand. It would not be practical/fair/possible to require a contributor to redo their feature/change to fit the new plumbing.
Another example I remember is Klemens’ idea to make error_code& a completion token per se, so c++20 syntax would not be burdened at all. Some 5-10 releases down the road we not only have a general family of token adapters (consign, as_tuple, redirect_error, cancel_after…) but even a default completion token that changed to default to asio::deferred_t. All in all, not only does redirect_error(ec) more or less do exactly what Klemens’ idea sketched, but we got the far superior solution where c++20 co_await syntax has the best of all worlds regardless of how errors are handled. This is not an example that started with concrete code by Klemens (if memory serves) but it sure serves as an example how the concrete ideas inspire re-imagined solutions rather than verbatim contributions.
Again, if we’re gonna stage an investigation into perceived plagiary or use of work without credit, that seems both a derailment of the topic (so warrants its own thread) and requires tangible examples.
Yeah, that's all well and good but I still think Chris could improve this dramatically here. I'm not sure if you've ever contributed to a large successful open-source project with tons of contributors, but the Linux kernel, for example, goes very much out of its way to credit people for their ideas, suggestions and bug finds. For example, I'm an early adopter of many io_uring features and I've authored the most sophisticated open-source io_uring runtime in both Rust and C++, though nowadays it's mostly Rust. You should check it out here: https://github.com/cmazakas/fiona-rs Because of this, you can see my name in the Linux commit messages: https://github.com/search?q=repo%3Atorvalds%2Flinux+%22mazakas%22&type=commi... Let's do the same for Vinicius... https://github.com/search?q=repo%3Achriskohlhoff%2Fasio+%22Oliveira%22&type=... Zero results. In general, I think it's absolutely fine for authors to take work and make it actually good for their projects. We want this to happen, actually. But we must also remember credit where it is due, and it seems like Chris does not have a good track record of this. I'm not saying this means he's plagiarizing but I do think it means a fork has value in that we can just genuinely be better open-source developers with the fork. People deserve attribution. - Christian