This re-review is happening because the original review had an indeterminate result (see my summary at https://lists.boost.org/archives/list/boost@lists.boost.org/message/2Q7UBOTE...) and resulted in my filing a number of issues against the library based on the reviewers comments. Now that Matt and Chris have been busy fixing these and addressing the reviewers concerns, the library is now back for a second look, see https://github.com/cppalliance/decimal/issues?q=is%3Aissue state%3Aclosed label%3A"Boost Review" for a complete list of issues addressed from the last review.
In addition to the issues list Boost Review here's a summary of the activities from the last 9 months: Breaking Changes: - Based on bitwise comparisons with other similar libraries and database software, we have changed the internal encoding of our IEEE 754-compliant types - We spent about 3 months optimizing just back end integer types that are now used throughout the library, and as the internals of decimal128_t - We have changed the type names to better match conventions: - `decimalXX` is now `decimalXX_t` - `decimalXX_fast` is now `decimal_fastXX_t` - The headers have been similarly renamed (e.g. decimal32.hpp -> decimal32_t.hpp), and can now be used independently instead of requiring the monolith based on feedback in Review - Constructors have been simplified to reduce confusion (no more double negative logic) - The default rounding mode has changed to align with IEEE 754, with rounding bugs being squashed across the modes as well Other Changes: - The documentation content has been overhauled thanks to feedback from Peter Turcan and others during the first review - The docs are no longer a single long page of Asciidoc; we have moved to Antora. Thanks to Joaquín and Christian for making it trivial to copy from Unordered to make that happen. - https://develop.decimal.cpp.al/ - We now support formatting with {fmt} - Benchmarks have been expanded to include GCC `_DecimalXX` types, and Intel's libbid. I think people should be pleased with the results now, since that was a huge point of contention at the end of the review - We have added support for CMake pkg config for ease of use Matt